Character Classes Missing { }

[bscan]

Hi @2colours, I reviewed the issue brought up in: microsoft/vscode#168319 (comment)

The issue is that 83d24d5 replaced p{Alpha} by \\pL\\pM which are not regex character classes in Oniguruma regexes. They should be \\p{L}\\p{M} instead.

The left shows with \\pL\\pM and the right shows with \\p{L}\\p{M}

\pL is a valid PCRE character class, and I see the idea came from #102 to use them since Linguist uses PCRE. \p{L} is valid in both PCRE and Oniguruma

[2colours]

Hi,

what can I say... it seems fairly annoying that we get problems merely because the same data is used simultaneously, by incompatible systems. (What is even more annoying is when you get to closed doors because you fixed some problems for a different user.)

If you are confident that this is the problem - it seems like you have invested into figuring it out - could you please submit a modified version as well? I will eventually get to it unless I forget but this seems like a good opportunity to lure more people into the way things work with this repo. :)

Cheers

[2colours]

@bscan ping - in case you missed the message. I might do it next week sometime if you don't want to get involved.

[2colours]

Okay, done now with ee64f96 - please re-open if there are further problems with it.

[bscan]

Thanks @2colours! Sorry for not getting back to you on this one. However, I just checked out https://github.com/alexr00/testraku and copied in your fixes for testing, and I can confirm that your new version fixes the issue. Thanks!