[Android Bootcamp] Review my Tip Calculator!

[RaphaelTurtlePower]

Hi,

Attached is my current version of the Tip Calculator. I tried many different things and pretty much just ran with it. There may be some coding faux-pas in there, which I can clean up in a little bit. For this iteration i was more concerned with getting the features across more than anything.
/cc @nesquena @timothy1ee

Thanks!
See you Tuesday, or today!
Christian Mamuad

P.S: Also, I created a new github account in honor of the coolest ninja turtle out of the 4 turtles, and I'm ditching my other account. Turtle Power!

[vibhorB]

👍 Excellent work Christian. A few notes after checking out the code:

• The app crashes as soon as I remove the input or type a character, I would recommend to fix the bug asap and update comment here when you have fixed that.
• Good to see you used setOnKeyListener for auto-updating bill, tip and amount per person.
• Good use of margins, sp/dp in view
• Good use of string resources for text values.
• Good use of different widgets for entering data(SeekBar)
• Good job with persistence to file and reading from it back on launch
• Good job with the UI changes of font, using images, colors, settings icon(and icons inside settings activity)
• Nice animation with TextSwitcher

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I'm glad you have started that early and I would encourage you to push the projects each week, continue adding your own UI elements and experimenting with optional features that improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this has given you a better sense of working with views and the RelativeLayout which is a very powerful layout system, probably one of the best responsive-first layout systems available across web and mobile platforms. The next assignment will build on top of the first concepts introduced here and will also introduce networking, api use, handling remote images and navigating between activities.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@thecodepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!

[RaphaelTurtlePower]

Hi,

Thanks for the feedback. I had not tested on an actual device before, so I tried it out and found the issue. Here are my updates:

1. Changed onKey listener to textwatcher onTextChanged listener. It seems onKey listener doesn't work for alphabet and numerical keys, but it works for Enter and DEL.
2. Added a handler for the Enter key so when you press Enter, the keyboard will disappear.
3. I also added inputType to the EditText field so the numerical keyboard is brought up instead of the standard keyboard.

If time permits, I will review the feedback guides and make the necessary adjustments.

I appreciate your input and your feedback. Thanks!
Christian