Merge pull request #118 from RasaHQ/fix/dbMigrationService_args

Fix args for the db migration service

Author: Tomasz Czekajlo

.github/workflows/ci.yml

@@ -37,6 +37,22 @@ jobs:
         command: lint
         config: ct.yaml
 
+  test:
+    name: Unit tests
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v2
+
+    - name: Install dependencies
+      run: |
+        helm dependency update ${CHART}
+        cd ./tests && go get -t || true
+
+    - name: Run tests
+      working-directory: ./tests
+      run: go test -v
+
   deploy_chart:
     name: Test the deployment of the chart
     runs-on: ubuntu-latest

charts/rasa-x/Chart.yaml

@@ -1,7 +1,7 @@
 ---
 apiVersion: v2
 
-version: "1.7.11"
+version: "1.7.12"
 
 appVersion: "0.33.0"
 

charts/rasa-x/templates/db-migration-service-deployment.yaml

@@ -38,11 +38,12 @@ spec:
           {{- toYaml .Values.dbMigrationService.command | nindent 10 }}
         {{- end }}
         args:
+        {{- if .Values.dbMigrationService.args }}
+          {{- toYaml .Values.dbMigrationService.args | nindent 10 }}
+        {{- else }}
           - python
           - -m
           - rasax.community.services.db_migration_service
-        {{- if .Values.dbMigrationService.args }}
-          {{- toYaml .Values.dbMigrationService.args | nindent 10 }}
         {{- end }}
         ports:
           - name: "http"

tests/db_migration_service_test.go

@@ -0,0 +1,64 @@
+package test
+
+import (
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	appsv1 "k8s.io/api/apps/v1"
+
+	"github.com/gruntwork-io/terratest/modules/helm"
+	"github.com/gruntwork-io/terratest/modules/k8s"
+	"github.com/gruntwork-io/terratest/modules/logger"
+	"github.com/gruntwork-io/terratest/modules/random"
+)
+
+var (
+	chart         string = "../charts/rasa-x"
+	releaseName   string = "rasa-x"
+	namespaceName string = "test-" + strings.ToLower(random.UniqueId())
+)
+
+func TestArgsDeployment(t *testing.T) {
+	t.Parallel()
+
+	// Path to the helm chart we will test
+	helmChartPath, err := filepath.Abs(chart)
+	require.NoError(t, err)
+
+	// Set up the namespace; confirm that the template renders the expected value for the namespace.
+	logger.Logf(t, "Namespace: %s\n", namespaceName)
+
+	// Setup the args. For this test, we will set the following input values:
+	// - dbMigrationService.args[0]=test
+	optionsWithValues := &helm.Options{
+		SetValues: map[string]string{
+			"dbMigrationService.args[0]": "test",
+		},
+		KubectlOptions: k8s.NewKubectlOptions("", "", namespaceName),
+	}
+
+	optionsWithoutValues := &helm.Options{
+		KubectlOptions: k8s.NewKubectlOptions("", "", namespaceName),
+	}
+
+	outputWithOptions := helm.RenderTemplate(t, optionsWithValues, helmChartPath, releaseName, []string{"templates/db-migration-service-deployment.yaml"})
+	outputWithoutOptions := helm.RenderTemplate(t, optionsWithoutValues, helmChartPath, releaseName, []string{"templates/db-migration-service-deployment.yaml"})
+
+	var deploymentWithOptions appsv1.Deployment
+	var deploymentWithoutOptions appsv1.Deployment
+	helm.UnmarshalK8SYaml(t, outputWithOptions, &deploymentWithOptions)
+	helm.UnmarshalK8SYaml(t, outputWithoutOptions, &deploymentWithoutOptions)
+
+	// Verify the deployment pod template spec is set to the expected values
+
+	renderedDeploymentWithOptions := deploymentWithOptions
+	renderedDeploymentWithoutOptions := deploymentWithoutOptions
+
+	require.Equal(t, len(renderedDeploymentWithOptions.Spec.Template.Spec.Containers), 1)
+	require.Equal(t, len(renderedDeploymentWithoutOptions.Spec.Template.Spec.Containers), 1)
+
+	require.Equal(t, renderedDeploymentWithOptions.Spec.Template.Spec.Containers[0].Args, []string{"test"})
+	require.Equal(t, renderedDeploymentWithoutOptions.Spec.Template.Spec.Containers[0].Args, []string{"python", "-m", "rasax.community.services.db_migration_service"})
+}