MPS documentation lacks a review procedure

[UNAA008]

The Memory Pool System pull request merge procedure Pre-merge checklist mentions code review as an implied requirement for merging but there is no accessible documentation to describe how such reviews should be carried out.

Some of the documentation required will become available when #95 is satisfied but a specific procedure and/or guide is needed to support reviewers properly.

[rptb1]

It seems sensible for review logs to appear in GitHub metadata like #67 (review)

[rptb1]

These are internal Ravenbrook documents at the moment. See #95.

Here are links to the formal MM group review procedure and its adjuncts the kickoff, entry, checking, logging, brainstorm, editing, and exit procedures.

Related useful documents include:

• Guide to classification of review issues
• Guidelines for review edits

Source material from "Software Inspections" [Gilb 1993]:

• A one-page inspection handbook
• An incomplete set of guides, policies, and rules (but they're all in the book) https://info.ravenbrook.com/project/mps/doc/2002-06-18/obsolete-mminfo/mminfo/book/gilb93/proc

Source material from "Key Practices of the Capability Maturity Model Version 1.1" (before the CMM turned into an industry):

• Peer reviews quoted from https://resources.sei.cmu.edu/asset_files/TechnicalReport/1993_005_001_16214.pdf pp 284-292.

In addition there are multiple rule sets and checklists, all built up over years of defect prevention:

• Rules of the MM group
• Checklists