From 25931a47a7dd5153fa6a0673a4eb7ef7b39baa71 Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Tue, 26 Nov 2024 23:52:59 +0000 Subject: [PATCH 1/2] Removing unused variable that triggered the unused-but-set-variable warning when building on macOS 14.7.1 with Clang 15.0. --- code/trans.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/code/trans.c b/code/trans.c index ba7b9b6fb1..98ee717c59 100644 --- a/code/trans.c +++ b/code/trans.c @@ -151,7 +151,6 @@ Res TransformAddOldNew(Transform transform, { Res res; Index i; - Count added = 0; Arena arena; AVERT(Transform, transform); @@ -190,8 +189,6 @@ Res TransformAddOldNew(Transform transform, AVER(res != ResFAIL); /* It's a static error to add the same old twice. */ if (res != ResOK) return res; - - ++added; } AVERT(Transform, transform); From 984d48ddd200c8e7fb1ccf4e29b47acfaaf9ce9f Mon Sep 17 00:00:00 2001 From: Richard Brooksby Date: Wed, 27 Nov 2024 12:49:13 +0000 Subject: [PATCH 2/2] Clarifying that two AVERs are implementing .assume.parked in response to review comment . --- code/trans.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/trans.c b/code/trans.c index 98ee717c59..90fb1e7fb3 100644 --- a/code/trans.c +++ b/code/trans.c @@ -163,8 +163,8 @@ Res TransformAddOldNew(Transform transform, lists (old_list, new_list), using ArenaRead. Insisting on parking keeps things simple. */ arena = transform->arena; - AVER(ArenaGlobals(arena)->clamped); - AVER(arena->busyTraces == TraceSetEMPTY); + AVER(ArenaGlobals(arena)->clamped); /* .assume.parked */ + AVER(arena->busyTraces == TraceSetEMPTY); /* .assume.parked */ res = TableGrow(transform->oldToNew, count); if (res != ResOK)