From 42b4ed4bae0e4c30fde9f44268c6d7a42de53b2d Mon Sep 17 00:00:00 2001
From: Vishwajith Shettigar
 <76042077+Vishwajith-Shettigar@users.noreply.github.com>
Date: Thu, 19 Oct 2023 04:12:48 +0530
Subject: [PATCH] Fix #5187  Textview contrast issue in locked lesson (#5189)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fixes #5187, changing the background color of the locked lessons'
TextView fixed the contrast ratio issue.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

Before Fix

| Light Mode| Dark Mode|
|--------|--------|
|
![textcontrast](https://github.com/oppia/oppia-android/assets/76042077/01ffdf6c-3a20-4ce5-ab20-54ff7a82fedee)|![testdark](https://github.com/oppia/oppia-android/assets/76042077/d3f1fb3a-f267-4ced-9a00-3bdd67d4192a)|

After Fix

| Light Mode| Dark Mode|
|--------|--------|
|
![afterlight](https://github.com/oppia/oppia-android/assets/76042077/7d00b264-0bfb-4b35-8b99-b0b44ff7149d)|![lockbackground](https://github.com/oppia/oppia-android/assets/76042077/9147686c-e573-4285-aced-0af599d68d67)|

<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
---
 app/src/main/res/values-night/color_palette.xml | 4 ++--
 app/src/main/res/values/color_palette.xml       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/res/values-night/color_palette.xml b/app/src/main/res/values-night/color_palette.xml
index 610b29c2ac1..36917970d4f 100644
--- a/app/src/main/res/values-night/color_palette.xml
+++ b/app/src/main/res/values-night/color_palette.xml
@@ -171,9 +171,9 @@
   <color name="color_palette_shared_card_border_stroke_color">@color/color_def_accessible_light_grey_2</color>
   <color name="color_palette_lesson_in_progress_chapter_index_background_color">@color/color_def_oppia_green</color>
   <color name="color_palette_lesson_in_progress_chapter_name_background_color">@color/color_def_accessible_grey</color>
-  <color name="color_palette_lessons_locked_chapter_container_background_color">@color/color_def_accessible_light_grey_2</color>
+  <color name="color_palette_lessons_locked_chapter_container_background_color">@color/color_def_accessible_light_grey</color>
   <color name="color_palette_lesson_locked_chapter_name_text_color">@color/color_def_white_80</color>
-  <color name="color_palette_lesson_locked_chapter_name_background_color">@color/color_def_accessible_light_grey_2</color>
+  <color name="color_palette_lesson_locked_chapter_name_background_color">@color/color_def_accessible_light_grey</color>
   <color name="color_palette_lessons_locked_vertical_divider_color">@color/color_def_dark_silver</color>
   <color name="color_palette_lesson_not_started_stroke_color">@color/color_def_white</color>
   <color name="color_palette_lesson_not_started_chapter_name_background_color">@color/color_def_oppia_green</color>
diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml
index a542be65211..f5202bb9365 100644
--- a/app/src/main/res/values/color_palette.xml
+++ b/app/src/main/res/values/color_palette.xml
@@ -178,7 +178,7 @@
   <color name="color_palette_lesson_in_progress_chapter_name_background_color">@color/color_def_light_green</color>
   <color name="color_palette_lessons_locked_chapter_container_background_color">@color/color_def_accessible_light_grey_2</color>
   <color name="color_palette_lesson_locked_chapter_name_text_color">@color/color_def_accessible_light_grey_2</color>
-  <color name="color_palette_lesson_locked_chapter_name_background_color">@color/color_def_grey</color>
+  <color name="color_palette_lesson_locked_chapter_name_background_color">@color/color_def_oppia_grey_background</color>
   <color name="color_palette_lessons_locked_vertical_divider_color">@color/color_def_transparent</color>
   <color name="color_palette_lesson_not_started_stroke_color">@color/color_def_bright_green</color>
   <color name="color_palette_lesson_not_started_chapter_name_background_color">@color/color_def_white</color>