Skip to content

Commit a738807

Browse files
katamatataericbolikowski
katamatata
and
ericbolikowski
authored
fix(tp): hide the Munich job fair checkbox until a new date is announced (#833)
* Hide Munich job fair checkbox until new date announced * Update wording * rename winter => summer on backend --------- Co-authored-by: Eric Bolikowski <eric@binarylights.com>
1 parent 2a10577 commit a738807

File tree

32 files changed

+140
-131
lines changed

32 files changed

+140
-131
lines changed

‎apps/nestjs-api/src/tp-company-profiles/dtos/tp-company-profile-patch.entityinput.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export class TpCompanyProfilePatchInput extends PartialType(
1313
'companyName',
1414
'industry',
1515
'joinsDusseldorf24WinterJobFair',
16-
'joinsMunich24WinterJobFair',
16+
'joinsMunich24SummerJobFair',
1717
'isProfileVisibleToJobseekers',
1818
'linkedInUrl',
1919
'location',

‎apps/nestjs-api/src/tp-job-listings/args/find-all-visible-tp-jobseeker-profiles.args.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ class FindAllVisibleTpJobListingsArgsFilter {
2727

2828
isRemotePossible?: boolean
2929
joinsDusseldorf24WinterJobFair?: boolean
30-
joinsMunich24WinterJobFair?: boolean
30+
joinsMunich24SummerJobFair?: boolean
3131
}

‎apps/nestjs-api/src/tp-job-listings/tp-job-listings.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ export class TpJobListingsService {
7171
filter['Account__r.ReDI_Joins_Dusseldorf_24_Winter_Job_Fair__c'] =
7272
_filter.filter.joinsDusseldorf24WinterJobFair
7373
}
74-
if (_filter.filter.joinsMunich24WinterJobFair) {
75-
filter['Account__r.ReDI_Joins_Munich_24_Winter_Job_Fair__c'] =
76-
_filter.filter.joinsMunich24WinterJobFair
74+
if (_filter.filter.joinsMunich24SummerJobFair) {
75+
filter['Account__r.ReDI_Joins_Munich_24_Summer_Job_Fair__c'] =
76+
_filter.filter.joinsMunich24SummerJobFair
7777
}
7878

7979
return await this.findAll(filter)

‎apps/nestjs-api/src/tp-jobseeker-directory-entries/args/find-all-visible-tp-jobseeker-directory-entries.args.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ class FindAllVisibleTpJobseekerDirectoryEntriesFilter {
2525
skills?: TpTechnicalSkill[]
2626
@Field((type) => [FederalState])
2727
federalStates?: FederalState[]
28+
joinsMunich24SummerJobFair?: boolean
2829
joinsDusseldorf24WinterJobFair?: boolean
29-
joinsMunich24WinterJobFair?: boolean
3030
}

‎apps/nestjs-api/src/tp-jobseeker-directory-entries/tp-jobseeker-directory-entries.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ export class TpJobseekerDirectoryEntriesService {
8383
filter.Jobseeker_Profiles__r.Joins_Dusseldorf_24_Winter_Job_Fair__c =
8484
_filter.filter.joinsDusseldorf24WinterJobFair
8585
}
86-
if (_filter.filter.joinsMunich24WinterJobFair) {
87-
filter.Jobseeker_Profiles__r.Joins_Munich_24_Winter_Job_Fair__c =
88-
_filter.filter.joinsMunich24WinterJobFair
86+
if (_filter.filter.joinsMunich24SummerJobFair) {
87+
filter.Jobseeker_Profiles__r.Joins_Munich_24_Summer_Job_Fair__c =
88+
_filter.filter.joinsMunich24SummerJobFair
8989
}
9090

9191
const entities = await this.findAll(filter)

‎apps/nestjs-api/src/tp-jobseeker-profile/dto/tp-jobseeker-profile-patch.entityinput.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export class TpJobseekerProfilePatchInput extends PartialType(
1515
'ifAvailabilityIsDate_date',
1616
'isHired',
1717
'joinsDusseldorf24WinterJobFair',
18-
'joinsMunich24WinterJobFair',
18+
'joinsMunich24SummerJobFair',
1919
'isProfileVisibleToCompanies',
2020
'location',
2121
'profileAvatarImageS3Key',

‎apps/redi-talent-pool/src/pages/app/browse/BrowseCompany.tsx

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export function BrowseCompany() {
5959
federalStates: withDefault(ArrayParam, []),
6060
onlyFavorites: withDefault(BooleanParam, undefined),
6161
joinsDusseldorf24WinterJobFair: withDefault(BooleanParam, undefined),
62-
joinsMunich24WinterJobFair: withDefault(BooleanParam, undefined),
62+
// joinsMunich24SummerJobFair: withDefault(BooleanParam, undefined),
6363
})
6464
const name = query.name
6565
const desiredLanguages = query.desiredLanguages as Language[]
@@ -69,7 +69,7 @@ export function BrowseCompany() {
6969
const federalStates = query.federalStates as FederalState[]
7070
const onlyFavorites = query.onlyFavorites
7171
const joinsDusseldorf24WinterJobFair = query.joinsDusseldorf24WinterJobFair
72-
const joinsMunich24WinterJobFair = query.joinsMunich24WinterJobFair
72+
// const joinsMunich24SummerJobFair = query.joinsMunich24SummerJobFair
7373

7474
const jobseekerProfilesQuery =
7575
useTpJobseekerDirectoryEntriesFindAllVisibleQuery({
@@ -81,7 +81,7 @@ export function BrowseCompany() {
8181
skills,
8282
federalStates,
8383
joinsDusseldorf24WinterJobFair,
84-
joinsMunich24WinterJobFair,
84+
// joinsMunich24SummerJobFair,
8585
},
8686
})
8787
const jobseekerProfiles =
@@ -132,12 +132,12 @@ export function BrowseCompany() {
132132
joinsDusseldorf24WinterJobFair === undefined ? true : undefined,
133133
}))
134134

135-
const toggleMunich24WinterJobFairFilter = () =>
136-
setQuery((latestQuery) => ({
137-
...latestQuery,
138-
joinsMunich24WinterJobFair:
139-
joinsMunich24WinterJobFair === undefined ? true : undefined,
140-
}))
135+
// const toggleMunich24SummerJobFairFilter = () =>
136+
// setQuery((latestQuery) => ({
137+
// ...latestQuery,
138+
// joinsMunich24SummerJobFair:
139+
// joinsMunich24SummerJobFair === undefined ? true : undefined,
140+
// }))
141141

142142
const setName = (value) => {
143143
setQuery((latestQuery) => ({ ...latestQuery, name: value || undefined }))
@@ -152,7 +152,7 @@ export function BrowseCompany() {
152152
employmentTypes: [],
153153
federalStates: [],
154154
joinsDusseldorf24WinterJobFair: undefined,
155-
joinsMunich24WinterJobFair: undefined,
155+
// joinsMunich24SummerJobFair: undefined,
156156
}))
157157
}
158158

@@ -162,8 +162,8 @@ export function BrowseCompany() {
162162
desiredPositions.length !== 0 ||
163163
federalStates.length !== 0 ||
164164
employmentTypes.length !== 0 ||
165-
joinsDusseldorf24WinterJobFair ||
166-
joinsMunich24WinterJobFair
165+
joinsDusseldorf24WinterJobFair
166+
// || joinsMunich24SummerJobFair
167167

168168
return (
169169
<LoggedIn>
@@ -264,25 +264,26 @@ export function BrowseCompany() {
264264
size="small"
265265
/>
266266
</div>
267-
{/* Hidden until the next Job Fair date announced */}
268267
<div className="filters-inner">
269268
<Checkbox
270269
name="joinsDusseldorf24WinterJobFair"
271270
checked={joinsDusseldorf24WinterJobFair || false}
272271
handleChange={toggleDusseldorf24WinterJobFairFilter}
273272
>
274-
Attending ReDI Düsseldorf Winter Job Fair 2024
273+
ReDI Düsseldorf Winter Job Fair 2024
275274
</Checkbox>
276275
</div>
277-
<div className="filters-inner">
276+
<div className="filters-inner"></div>
277+
{/* Hidden until the next Job Fair date announced */}
278+
{/* <div className="filters-inner">
278279
<Checkbox
279-
name="joinsMunich24WinterJobFair"
280-
checked={joinsMunich24WinterJobFair || false}
281-
handleChange={toggleMunich24WinterJobFairFilter}
280+
name="joinsMunich24SummerJobFair"
281+
checked={joinsMunich24SummerJobFair || false}
282+
handleChange={toggleMunich24SummerJobFairFilter}
282283
>
283-
Attending ReDI Munich Winter Job Fair 2024
284+
ReDI Munich Winter Job Fair 2024
284285
</Checkbox>
285-
</div>
286+
</div> */}
286287
</div>
287288

288289
<div className="active-filters">
@@ -344,14 +345,14 @@ export function BrowseCompany() {
344345
onClickHandler={toggleDusseldorf24WinterJobFairFilter}
345346
/>
346347
)}
347-
{joinsMunich24WinterJobFair && (
348+
{/* {joinsMunich24SummerJobFair && (
348349
<FilterTag
349350
key="redi-munich-winter-job-fair-2024-filter"
350351
id="redi-munich-winter-job-fair-2024-filter"
351352
label="ReDI Munich Winter Job Fair 2024"
352-
onClickHandler={toggleMunich24WinterJobFairFilter}
353+
onClickHandler={toggleMunich24SummerJobFairFilter}
353354
/>
354-
)}
355+
)} */}
355356
<span className="active-filters__clear-all" onClick={clearFilters}>
356357
Delete all filters
357358
<Icon icon="cancel" size="small" space="left" />

‎apps/redi-talent-pool/src/pages/app/browse/BrowseJobseeker.tsx

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export function BrowseJobseeker() {
6161
onlyFavorites: withDefault(BooleanParam, undefined),
6262
isRemotePossible: withDefault(BooleanParam, undefined),
6363
joinsDusseldorf24WinterJobFair: withDefault(BooleanParam, undefined),
64-
joinsMunich24WinterJobFair: withDefault(BooleanParam, undefined),
64+
// joinsMunich24SummerJobFair: withDefault(BooleanParam, undefined),
6565
})
6666
const relatedPositions = query.relatedPositions as TpDesiredPosition[]
6767
const idealTechnicalSkills = query.idealTechnicalSkills as TpTechnicalSkill[]
@@ -70,7 +70,7 @@ export function BrowseJobseeker() {
7070
const onlyFavorites = query.onlyFavorites
7171
const isRemotePossible = query.isRemotePossible
7272
const joinsDusseldorf24WinterJobFair = query.joinsDusseldorf24WinterJobFair
73-
const joinsMunich24WinterJobFair = query.joinsMunich24WinterJobFair
73+
// const joinsMunich24SummerJobFair = query.joinsMunich24SummerJobFair
7474

7575
const jobListingsQuery = useTpJobListingFindAllVisibleQuery({
7676
input: {
@@ -80,7 +80,7 @@ export function BrowseJobseeker() {
8080
federalStates,
8181
isRemotePossible,
8282
joinsDusseldorf24WinterJobFair,
83-
joinsMunich24WinterJobFair,
83+
// joinsMunich24SummerJobFair,
8484
},
8585
})
8686
const jobListings = jobListingsQuery.data?.tpJobListings
@@ -130,12 +130,13 @@ export function BrowseJobseeker() {
130130
joinsDusseldorf24WinterJobFair === undefined ? true : undefined,
131131
}))
132132

133-
const toggleMunich24WinterJobFairFilter = () =>
134-
setQuery((latestQuery) => ({
135-
...latestQuery,
136-
joinsMunich24WinterJobFair:
137-
joinsMunich24WinterJobFair === undefined ? true : undefined,
138-
}))
133+
// Hidden until the new date announced
134+
// const toggleMunich24SummerJobFairFilter = () =>
135+
// setQuery((latestQuery) => ({
136+
// ...latestQuery,
137+
// joinsMunich24SummerJobFair:
138+
// joinsMunich24SummerJobFair === undefined ? true : undefined,
139+
// }))
139140

140141
const clearFilters = () => {
141142
setQuery((latestQuery) => ({
@@ -146,7 +147,7 @@ export function BrowseJobseeker() {
146147
federalStates: [],
147148
isRemotePossible: undefined,
148149
joinsDusseldorf24WinterJobFair: undefined,
149-
joinsMunich24WinterJobFair: undefined,
150+
// joinsMunich24SummerJobFair: undefined,
150151
}))
151152
}
152153

@@ -156,8 +157,8 @@ export function BrowseJobseeker() {
156157
employmentType.length !== 0 ||
157158
federalStates.length !== 0 ||
158159
isRemotePossible ||
159-
joinsDusseldorf24WinterJobFair ||
160-
joinsMunich24WinterJobFair
160+
joinsDusseldorf24WinterJobFair
161+
// || joinsMunich24SummerJobFair
161162

162163
// Redirect to homepage if user is not supposed to be browsing yet
163164
if (
@@ -284,10 +285,6 @@ export function BrowseJobseeker() {
284285
size="small"
285286
/>
286287
</div>
287-
<div className="filters-inner"></div>
288-
</div>
289-
{/* Hidden until the next Job Fair date announced */}
290-
<div className="filters">
291288
<div className="filters-inner">
292289
<Checkbox
293290
name="joinsDuesseldorf24WinterJobFair"
@@ -297,17 +294,20 @@ export function BrowseJobseeker() {
297294
ReDI Düsseldorf Winter Job Fair 2024
298295
</Checkbox>
299296
</div>
300-
<div className="filters-inner">
301-
<Checkbox
297+
</div>
298+
{/* Hidden until the next Job Fair date announced */}
299+
{/* <div className="filters"> */}
300+
{/* <div className="filters-inner"> */}
301+
{/* <Checkbox
302302
name="joinsMuich24WinterJobFair"
303-
checked={joinsMunich24WinterJobFair || false}
304-
handleChange={toggleMunich24WinterJobFairFilter}
303+
checked={joinsMunich24SummerJobFair || false}
304+
handleChange={toggleMunich24SummerJobFairFilter}
305305
>
306306
ReDI Munich Winter Job Fair 2024
307-
</Checkbox>
308-
</div>
309-
<div className="filters-inner"></div>
310-
</div>
307+
</Checkbox> */}
308+
{/* </div> */}
309+
{/* <div className="filters-inner"></div> */}
310+
{/* </div> */}
311311

312312
<div className="active-filters">
313313
{shouldShowFilters && (
@@ -372,14 +372,14 @@ export function BrowseJobseeker() {
372372
onClickHandler={toggleDusseldorf24WinterJobFair}
373373
/>
374374
)}
375-
{joinsMunich24WinterJobFair && (
375+
{/* {joinsMunich24SummerJobFair && (
376376
<FilterTag
377377
key="redi-munich-winter-job-fair-2024-filter"
378378
id="redi-munich-winter-job-fair-2024-filter"
379379
label="ReDI Munich Winter Job Fair 2024"
380-
onClickHandler={toggleMunich24WinterJobFairFilter}
380+
onClickHandler={toggleMunich24SummerJobFairFilter}
381381
/>
382-
)}
382+
)} */}
383383
<span className="active-filters__clear-all" onClick={clearFilters}>
384384
Delete all filters
385385
<Icon icon="cancel" size="small" space="left" />

‎apps/redi-talent-pool/src/pages/app/job-listing/JobListing.generated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export type FindOneJobListingQueryVariables = Types.Exact<{
1111
}>;
1212

1313

14-
export type FindOneJobListingQuery = { __typename?: 'Query', tpJobListing: { __typename?: 'TpJobListing', createdAt: any, expiresAt?: any | null, status?: Types.TpJobListingStatus | null, title?: string | null, updatedAt: any, employmentType?: Types.TpEmploymentType | null, id: string, idealTechnicalSkills?: Array<Types.TpTechnicalSkill> | null, isRemotePossible?: boolean | null, languageRequirements?: string | null, location?: string | null, relatesToPositions?: Array<Types.TpDesiredPosition> | null, salaryRange?: string | null, summary?: string | null, companyProfileId: string, companyName: string, profileAvatarImageS3Key?: string | null, federalState?: Types.FederalState | null, companyProfile: { __typename?: 'TpCompanyProfile', id: string, profileAvatarImageS3Key?: string | null, companyName: string, location?: string | null, tagline?: string | null, industry?: string | null, website?: string | null, linkedInUrl?: string | null, telephoneNumber?: string | null, about?: string | null, state: Types.CompanyTalentPoolState, isProfileVisibleToJobseekers: boolean, joinsDusseldorf24WinterJobFair?: boolean | null, joinsMunich24WinterJobFair?: boolean | null, createdAt: any, updatedAt: any, companyRepresentatives: Array<{ __typename?: 'UserContact', id: string, behanceUrl?: string | null, lastName: string, linkedInProfileUrl?: string | null, loopbackUserId: string, personalDescription?: string | null, personalWebsite?: string | null, postalMailingAddress?: string | null, slackUsername?: string | null, stackOverflowUrl?: string | null, telephoneNumber?: string | null, birthDate?: any | null, twitterUrl?: string | null, updatedAt: any, createdAt: any, dribbbleUrl?: string | null, email: string, firstName: string, gender?: Types.Gender | null, githubProfileUrl?: string | null, howDidHearAboutRediKey?: Types.FirstPointOfTpContactOption | null, howDidHearAboutRediOtherText?: string | null }> } } };
14+
export type FindOneJobListingQuery = { __typename?: 'Query', tpJobListing: { __typename?: 'TpJobListing', createdAt: any, expiresAt?: any | null, status?: Types.TpJobListingStatus | null, title?: string | null, updatedAt: any, employmentType?: Types.TpEmploymentType | null, id: string, idealTechnicalSkills?: Array<Types.TpTechnicalSkill> | null, isRemotePossible?: boolean | null, languageRequirements?: string | null, location?: string | null, relatesToPositions?: Array<Types.TpDesiredPosition> | null, salaryRange?: string | null, summary?: string | null, companyProfileId: string, companyName: string, profileAvatarImageS3Key?: string | null, federalState?: Types.FederalState | null, companyProfile: { __typename?: 'TpCompanyProfile', id: string, profileAvatarImageS3Key?: string | null, companyName: string, location?: string | null, tagline?: string | null, industry?: string | null, website?: string | null, linkedInUrl?: string | null, telephoneNumber?: string | null, about?: string | null, state: Types.CompanyTalentPoolState, isProfileVisibleToJobseekers: boolean, joinsDusseldorf24WinterJobFair?: boolean | null, joinsMunich24SummerJobFair?: boolean | null, createdAt: any, updatedAt: any, companyRepresentatives: Array<{ __typename?: 'UserContact', id: string, behanceUrl?: string | null, lastName: string, linkedInProfileUrl?: string | null, loopbackUserId: string, personalDescription?: string | null, personalWebsite?: string | null, postalMailingAddress?: string | null, slackUsername?: string | null, stackOverflowUrl?: string | null, telephoneNumber?: string | null, birthDate?: any | null, twitterUrl?: string | null, updatedAt: any, createdAt: any, dribbbleUrl?: string | null, email: string, firstName: string, gender?: Types.Gender | null, githubProfileUrl?: string | null, howDidHearAboutRediKey?: Types.FirstPointOfTpContactOption | null, howDidHearAboutRediOtherText?: string | null }> } } };
1515

1616

1717
export const FindOneJobListingDocument = `

‎apps/redi-talent-pool/src/pages/app/jobseeker-profile/JobseekerProfileForJobseekerEyes.tsx

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,15 @@ export function JobseekerProfileForJobseekerEyes() {
5555
queryClient.invalidateQueries()
5656
}
5757

58-
const onMunich24WinterJobFairParticipateChange = async () => {
59-
await mutation.mutateAsync({
60-
input: {
61-
joinsMunich24WinterJobFair: !profile?.joinsMunich24WinterJobFair,
62-
},
63-
})
64-
queryClient.invalidateQueries()
65-
}
58+
// Hidden until the new date announced
59+
// const onMunich24SummerJobFairParticipateChange = async () => {
60+
// await mutation.mutateAsync({
61+
// input: {
62+
// joinsMunich24SummerJobFair: !profile?.joinsMunich24SummerJobFair,
63+
// },
64+
// })
65+
// queryClient.invalidateQueries()
66+
// }
6667

6768
return (
6869
<LoggedIn>
@@ -89,24 +90,24 @@ export function JobseekerProfileForJobseekerEyes() {
8990
<OnboardingSteps />
9091
</div>
9192
<EditableNamePhotoLocation profile={profile} />
92-
{/* Hidden until the next Job Fair date announced */}
9393
<div style={{ marginBottom: '1.5rem' }}>
9494
<Checkbox
9595
checked={profile?.joinsDusseldorf24WinterJobFair}
9696
customOnChange={onDusseldorf24WinterJobFairParticipateChange}
97-
disabled={profile?.joinsMunich24WinterJobFair}
97+
disabled={profile?.joinsMunich24SummerJobFair}
9898
>
9999
I will attend the <b>ReDI Winter Job Fair in Düsseldorf</b> on{' '}
100100
<b>02/02/2024</b>.
101101
</Checkbox>
102-
<Checkbox
103-
checked={profile?.joinsMunich24WinterJobFair}
104-
customOnChange={onMunich24WinterJobFairParticipateChange}
102+
{/* Hidden until the next Job Fair date announced */}
103+
{/* <Checkbox
104+
checked={profile?.joinsMunich24SummerJobFair}
105+
customOnChange={onMunich24SummerJobFairParticipateChange}
105106
disabled={profile?.joinsDusseldorf24WinterJobFair}
106107
>
107108
I will attend the <b>ReDI Winter Job Fair in Munich</b> on{' '}
108109
<b>22/02/2024</b>.
109-
</Checkbox>
110+
</Checkbox> */}
110111
</div>
111112
<EditableOverview profile={profile} />
112113
<EditableSummary profile={profile} />

0 commit comments

Comments
 (0)