Sign-in fix

[A2Sumie]

I saw duplicates but upstream seems to have a fix?
microg#3257

[oSumAtrIX]

Can you produce the log:

org.microg.gms.common.NotOkayException: Error=MissingDroidguard
 at org.microg.gms.common.HttpFormClient.request(HttpFormClient.java:96)
at org.microg.gms.common.HttpFormClient.lambda$requestAsync$0(HttpFormClient.java:210)
at org.microg.gms.common.HttpFormClient$$ExternalSyntheticLambda0.run(Unknown Source:8)

when logging in

[A2Sumie]

Can you produce the log:

org.microg.gms.common.NotOkayException: Error=MissingDroidguard
 at org.microg.gms.common.HttpFormClient.request(HttpFormClient.java:96)
at org.microg.gms.common.HttpFormClient.lambda$requestAsync$0(HttpFormClient.java:210)
at org.microg.gms.common.HttpFormClient$$ExternalSyntheticLambda0.run(Unknown Source:8)

when logging in

sorry i can't...not w/ my pc right now
Actually just lost my phone and got blocked in revanced microG on my backup phone, instructions in other issues helped though

[riftrogue]

here

02-13 09:43:21.832 18359 32260 W GmsAuthLoginBrowser: onException
02-13 09:43:21.832 18359 32260 W GmsAuthLoginBrowser: java.io.IOException: Error=MissingDroidguard
02-13 09:43:21.832 18359 32260 W GmsAuthLoginBrowser: at org.microg.gms.common.HttpFormClient.request(HttpFormClient.java:96)
02-13 09:43:21.832 18359 32260 W GmsAuthLoginBrowser: at org.microg.gms.common.HttpFormClient$1.run(HttpFormClient.java:212) 

[oSumAtrIX]

Great, that means we can bump to fix, I'll update GmsCore to latest while at that

[er13]

@oSumAtrIX
I believe the upstream fix is incomplete (s. this comment) and actually an unnecessary hack and could/should be solved using the existing annotations (s. this comment).

Could you please wait a bit with releasing a new version until upstream developer responses to my comments and then rebase if necessary? Thanks!

[oSumAtrIX]

Sounds good, I'm still updating it in the meantime

[oSumAtrIX]

pushed the fix

[er13]

@oSumAtrIX
Unfortunately, the upstream developer has not responded yet. But I'm quite sure he missed this line, which wouldn't have happened if he had used the designated annotation instead of hacking it in at every call point.

[oSumAtrIX]

Thats fine, we can upstream again, this fork is simply merging from upstream

[oSumAtrIX]

The release is now online, someone should test if it works fine, in the meantime i am adjusting the patches to work with it (the current ones will work too) & implement an update check as well on the patch side. Ill also make an inapp announcement for yt to update