Skip to content

Commit 2d120e3

Browse files
committed
gradlew check finishes successfully
1 parent bca54b6 commit 2d120e3

File tree

10 files changed

+46
-30
lines changed

10 files changed

+46
-30
lines changed

android/memoryleaktest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ apply plugin: 'kotlin-android'
44
android {
55
flavorDimensions "target_platform"
66

7-
compileSdkVersion 31
7+
compileSdkVersion 33
88
defaultConfig {
99
applicationId "com.example.memoryleaktest"
1010
minSdkVersion 24
11-
targetSdkVersion 31
11+
targetSdkVersion 33
1212
versionCode 1
1313
versionName "1.0"
1414

android/memoryleaktest/src/main/AndroidManifest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
package="com.example.memoryleaktest">
4+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
45

6+
<uses-feature
7+
android:name="android.hardware.camera"
8+
android:required="true" />
59
<queries>
610
<package android:name="com.google.ar.core" />
711
</queries>

android/nativetest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ apply plugin: 'com.android.application'
22

33
android {
44
flavorDimensions "target_platform"
5-
compileSdkVersion 31
5+
compileSdkVersion 33
66

77
defaultConfig {
88
applicationId "com.viro.nativetest"
99
minSdkVersion 24
10-
targetSdkVersion 31
10+
targetSdkVersion 33
1111
versionCode 1
1212
versionName "1.0"
1313
missingDimensionStrategy 'product', 'viro_core'

android/nativetest/src/main/AndroidManifest.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,17 @@
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
44
package="com.viromedia.nativetest">
5+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
56

7+
<uses-feature
8+
android:name="android.hardware.camera"
9+
android:required="true" />
610
<queries>
711
<package android:name="com.google.ar.core" />
812
</queries>
913

1014
<!-- Required to read the paired viewer's distortion parameters -->
11-
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
15+
<!-- <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />-->
1216

1317
<!-- Required for AR -->
1418
<uses-permission android:name="android.permission.CAMERA" />

android/releasetest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ apply plugin: 'kotlin-android'
33

44
android {
55
flavorDimensions "target_platform"
6-
compileSdkVersion 31
6+
compileSdkVersion 33
77

88
defaultConfig {
99
applicationId "com.viromedia.releasetest"
1010
minSdkVersion 24
11-
targetSdkVersion 31
11+
targetSdkVersion 33
1212
versionCode 1
1313
versionName "1.0"
1414

android/releasetest/src/main/AndroidManifest.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,17 @@
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
44
package="com.viromedia.releasetest">
5+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
56

7+
<uses-feature
8+
android:name="android.hardware.camera"
9+
android:required="true" />
610
<queries>
711
<package android:name="com.google.ar.core"/>
812
</queries>
913

1014
<!-- Required to read the paired viewer's distortion parameters -->
11-
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
15+
<!-- <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />-->
1216

1317
<!-- Required for AR -->
1418
<uses-permission android:name="android.permission.CAMERA" />

android/renderertest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ apply plugin: 'com.android.application'
22

33
android {
44
flavorDimensions "target_platform"
5-
compileSdkVersion 31
5+
compileSdkVersion 33
66

77
defaultConfig {
88
applicationId "com.viromedia.renderertest"
99
minSdkVersion 24
10-
targetSdkVersion 31
10+
targetSdkVersion 33
1111
versionCode 1
1212
versionName "1.0"
1313
missingDimensionStrategy 'product', 'viro_core'

android/renderertest/src/main/AndroidManifest.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,19 @@
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
44
package="com.viromedia.renderertest">
5+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
56

7+
<uses-feature
8+
android:name="android.hardware.camera"
9+
android:required="true" />
610
<queries>
711
<package android:name="com.google.ar.core" />
812
</queries>
913

1014
<uses-permission android:name="android.permission.INTERNET" />
1115

1216
<!-- Required to read the paired viewer's distortion parameters -->
13-
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
17+
<!-- <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />-->
1418

1519
<!-- Required for AR -->
1620
<uses-permission android:name="android.permission.CAMERA" />

android/sharedCode/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
99
<uses-permission android:name="android.permission.VIBRATE"/>
1010
<!-- Required to read the paired viewer's distortion parameters. -->
11-
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
11+
<!-- <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>-->
1212
<!-- Required for Recording -->
1313
<uses-permission android:name="android.permission.RECORD_AUDIO" />
1414

android/sharedCode/src/main/java/com/viro/core/internal/AVPlayer.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import com.google.android.exoplayer2.C;
3434
import com.google.android.exoplayer2.DefaultLoadControl;
3535
import com.google.android.exoplayer2.ExoPlayer;
36+
import com.google.android.exoplayer2.MediaItem;
3637
import com.google.android.exoplayer2.PlaybackException;
3738
import com.google.android.exoplayer2.Player;
3839
import com.google.android.exoplayer2.SimpleExoPlayer;
@@ -71,7 +72,7 @@ private enum State {
7172
STARTED,
7273
}
7374

74-
private final SimpleExoPlayer mExoPlayer;
75+
private final ExoPlayer mExoPlayer;
7576
private float mVolume;
7677
private final long mNativeReference;
7778
private boolean mLoop;
@@ -88,13 +89,12 @@ public AVPlayer(long nativeReference, Context context) {
8889
mMute = false;
8990

9091
AdaptiveTrackSelection.Factory trackSelectionFactory = new AdaptiveTrackSelection.Factory();
91-
DefaultTrackSelector trackSelector = new DefaultTrackSelector(trackSelectionFactory);
92-
mExoPlayer = new SimpleExoPlayer.Builder(context).setTrackSelector(trackSelector).setLoadControl(new DefaultLoadControl()).build();
93-
94-
mExoPlayer.addListener(new Player.EventListener() {
92+
DefaultTrackSelector trackSelector = new DefaultTrackSelector(context, trackSelectionFactory);
93+
mExoPlayer = new ExoPlayer.Builder(context).setTrackSelector(trackSelector).setLoadControl(new DefaultLoadControl()).build();
9594

95+
mExoPlayer.addListener(new Player.Listener() {
9696
@Override
97-
public void onPlayerStateChanged(boolean playWhenReady, int playbackState) {
97+
public void onPlaybackStateChanged(@Player.State int playbackState) {
9898
// this function sometimes gets called back w/ the same playbackState.
9999
if (mPrevExoPlayerState == playbackState) {
100100
return;
@@ -175,34 +175,34 @@ public DataSource createDataSource() {
175175
private MediaSource buildMediaSource(Uri uri, DataSource.Factory mediaDataSourceFactory, ExtractorsFactory extractorsFactory) {
176176
int type = inferContentType(uri);
177177
switch (type) {
178-
case C.TYPE_SS:
179-
return new SsMediaSource.Factory(mediaDataSourceFactory).createMediaSource(uri);
180-
case C.TYPE_DASH:
181-
return new DashMediaSource.Factory(mediaDataSourceFactory).createMediaSource(uri);
182-
case C.TYPE_HLS:
183-
return new HlsMediaSource.Factory(mediaDataSourceFactory).createMediaSource(uri);
178+
case C.CONTENT_TYPE_SS:
179+
return new SsMediaSource.Factory(mediaDataSourceFactory).createMediaSource(MediaItem.fromUri(uri));
180+
case C.CONTENT_TYPE_DASH:
181+
return new DashMediaSource.Factory(mediaDataSourceFactory).createMediaSource(MediaItem.fromUri(uri));
182+
case C.CONTENT_TYPE_HLS:
183+
return new HlsMediaSource.Factory(mediaDataSourceFactory).createMediaSource(MediaItem.fromUri(uri));
184184
default:
185185
// Return an ExtraMediaSource as default.
186-
return new ProgressiveMediaSource.Factory(mediaDataSourceFactory, extractorsFactory).createMediaSource(uri);
186+
return new ProgressiveMediaSource.Factory(mediaDataSourceFactory, extractorsFactory).createMediaSource(MediaItem.fromUri(uri));
187187
}
188188
}
189189

190190
private int inferContentType(Uri uri) {
191191
String path = uri.getPath();
192-
return path == null ? C.TYPE_OTHER : inferContentType(path);
192+
return path == null ? C.CONTENT_TYPE_OTHER : inferContentType(path);
193193
}
194194

195195
private int inferContentType(String fileName) {
196196
fileName = Ascii.toLowerCase(fileName);
197197
if (fileName.endsWith(".mpd")) {
198-
return C.TYPE_DASH;
198+
return C.CONTENT_TYPE_DASH;
199199
} else if (fileName.endsWith(".m3u8")) {
200-
return C.TYPE_HLS;
200+
return C.CONTENT_TYPE_HLS;
201201
} else if (fileName.endsWith(".ism") || fileName.endsWith(".isml")
202202
|| fileName.endsWith(".ism/manifest") || fileName.endsWith(".isml/manifest")) {
203-
return C.TYPE_SS;
203+
return C.CONTENT_TYPE_SS;
204204
} else {
205-
return C.TYPE_OTHER;
205+
return C.CONTENT_TYPE_OTHER;
206206
}
207207
}
208208

0 commit comments

Comments
 (0)