Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what you can do with the .subscribe Disposable #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmewett
Copy link

@tmewett tmewett commented Feb 2, 2023

Not certain this is right, please correct :)

Disposable nor DisposableBase are not documented so it wasn't clear what you could do with them.

@coveralls
Copy link

coveralls commented Feb 3, 2023

Coverage Status

coverage: 93.433%. remained the same
when pulling d749d32 on tmewett:patch-1
into af1663d on ReactiveX:master.

@MainRo
Copy link
Collaborator

MainRo commented Feb 3, 2023

Thanks, yes it good to precise it here. Especially because many small examples do not show the disposal.

@dbrattli I do not understand why the code-quality check fails while they succeed on master.

@matiboy
Copy link
Collaborator

matiboy commented Feb 7, 2023

@MainRo @dbrattli

@dbrattli I do not understand why the code-quality check fails while they succeed on master.

There appears to be an issue with isort/poetry which caused issues on multiple repos that depend on this pre-commit; it is fixed in 5.12 and in 5.11.5 (for python 3.7 compatibility)

https://github.com/PyCQA/isort/releases/tag/5.11.5

On #689 I attempted to bump isort to that version but my Poetry appears to be a more recent version and made a lot of changes so had to revert.

@tmewett
Copy link
Author

tmewett commented Feb 28, 2024

Can this be merged?

@tmewett
Copy link
Author

tmewett commented Sep 23, 2024

👀 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants