From a50c7b173455c61a6b496e2188a90a58770121cc Mon Sep 17 00:00:00 2001
From: Dhruv <dhruvsharma1962000@gmail.com>
Date: Tue, 10 Oct 2023 16:02:34 +0530
Subject: [PATCH] Refactored code and written test case

---
 __test__/index.test.js | 14 ++++++++++++++
 js/index.js            | 15 +++++++++------
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/__test__/index.test.js b/__test__/index.test.js
index ed410e02..4c7d2524 100644
--- a/__test__/index.test.js
+++ b/__test__/index.test.js
@@ -1,5 +1,6 @@
 const puppeteer = require('puppeteer');
 const timeout = 25000;
+const checkDialog = require('../js/index');
 
 describe('Dummy Test ', () => {
   beforeAll(async () => {
@@ -23,3 +24,16 @@ describe('Dummy Test ', () => {
     timeout,
   );
 });
+
+describe('index function test case', () => {
+  test('should show dialog if open in phone', () => {
+    const regexp = /android|iphone|kindle|ipad/i; // for Mobile phone
+    const result = checkDialog(regexp);
+    expect(result).toBe('true');
+  });
+  test(`don't show dialog if not open in phone`, () => {
+    const regexp = /Windows|macOS|/i; // for PC
+    const result = checkDialog(regexp);
+    expect(result).toBe('false');
+  });
+});
diff --git a/js/index.js b/js/index.js
index 24b45104..cdb5689d 100644
--- a/js/index.js
+++ b/js/index.js
@@ -14,20 +14,23 @@ const numOfMembers = 5;
 let memberSection = document.getElementById('members');
 
 let regexp = /android|iphone|kindle|ipad/i;
-let details = navigator.userAgent;
-let isMobileDevice = regexp.test(details);
-window.onload = femo();
+isOpenInPhone(regexp);
+
+export function isOpenInPhone(type) {
+  let details = navigator.userAgent;
+  let isMobileDevice = type.test(details);
 
-function femo() {
-  console.log('efd');
   if (isMobileDevice) {
     openDialog();
     document.getElementById('okayBt').addEventListener('click', openApp);
     document.getElementById('cancleBt').addEventListener('click', closeDialog);
+    return true;
   } else {
     closeDialog();
+    return false;
   }
 }
+
 function openDialog() {
   document.querySelectorAll('.appDialog')[0].style.display = 'block';
   document.querySelectorAll('.mainDiv')[0].style.display = 'none';
@@ -36,7 +39,7 @@ function closeDialog() {
   document.querySelectorAll('.appDialog')[0].style.display = 'none';
   document.querySelectorAll('.mainDiv')[0].style.display = 'block';
 }
-function openApp() {
+function openRDSApp() {
   var flag = false;
   var appScheme = 'app://realdevsquad.com';
   var fallbackURL =