From 3594838ab4a78201924ccc15407f7203c750a61c Mon Sep 17 00:00:00 2001
From: vinit717 <vinit224488@gmail.com>
Date: Wed, 18 Feb 2026 00:04:04 +0530
Subject: [PATCH 1/3] fix: reset allMavens array and update test expectations
 for idle user counts

---
 models/discordactions.js                | 2 ++
 test/unit/models/discordactions.test.js | 8 ++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/models/discordactions.js b/models/discordactions.js
index 54d91aa84..70b644ce9 100644
--- a/models/discordactions.js
+++ b/models/discordactions.js
@@ -405,6 +405,8 @@ const updateIdleUsersOnDiscord = async (dev) => {
   let groupIdleRole;
   let groupIdleRoleId;
 
+  allMavens.length = 0;
+
   try {
     groupIdleRole = await getGroupRole("group-idle");
     if (!groupIdleRole?.roleExists || !groupIdleRole?.role?.roleid) {
diff --git a/test/unit/models/discordactions.test.js b/test/unit/models/discordactions.test.js
index bd6084b66..6f4d20836 100644
--- a/test/unit/models/discordactions.test.js
+++ b/test/unit/models/discordactions.test.js
@@ -1037,7 +1037,7 @@ describe("discordactions", function () {
 
       getDiscordMembers[3] = {
         ...getDiscordMembers[3],
-        roles: ["1212121212"],
+        roles: ["3434343434"],
       };
 
       await addUser(userData[0]);
@@ -1079,11 +1079,11 @@ describe("discordactions", function () {
       await cleanDb();
     });
 
-    it("should return  totalIdleUsers as 1,totalArchivedUsers as 0, totalRoleToBeAdded as 1", async function () {
+    it("should return  totalIdleUsers as 2,totalArchivedUsers as 0, totalRoleToBeAdded as 2", async function () {
       const dev = "true";
       const res = await updateIdleUsersOnDiscord(dev);
-      expect(res.totalIdleUsers).to.be.equal(1);
-      expect(res.totalUserRoleToBeAdded).to.be.equal(1);
+      expect(res.totalIdleUsers).to.be.equal(2);
+      expect(res.totalUserRoleToBeAdded).to.be.equal(2);
       expect(res.totalUserRoleToBeRemoved).to.be.equal(1);
       expect(res.totalArchivedUsers).to.be.equal(0);
     });

From bac213660d500e8bdfc35b289314f83c4d82cd6a Mon Sep 17 00:00:00 2001
From: vinit717 <vinit224488@gmail.com>
Date: Wed, 18 Feb 2026 21:41:36 +0530
Subject: [PATCH 2/3] fix: initialize allMavens array to prevent unintended
 side effects

---
 models/discordactions.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/models/discordactions.js b/models/discordactions.js
index 70b644ce9..1ab1e98cc 100644
--- a/models/discordactions.js
+++ b/models/discordactions.js
@@ -404,8 +404,7 @@ const updateIdleUsersOnDiscord = async (dev) => {
   let allUsersHavingGroupIdle = [];
   let groupIdleRole;
   let groupIdleRoleId;
-
-  allMavens.length = 0;
+  let allMavens = [];
 
   try {
     groupIdleRole = await getGroupRole("group-idle");

From 30171c3ccffdf75db33aa938baf08afb1d2e056c Mon Sep 17 00:00:00 2001
From: vinit717 <vinit224488@gmail.com>
Date: Wed, 18 Feb 2026 21:42:04 +0530
Subject: [PATCH 3/3] fix: change allMavens declaration from let to const for
 better immutability

---
 models/discordactions.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/models/discordactions.js b/models/discordactions.js
index 1ab1e98cc..0937b8869 100644
--- a/models/discordactions.js
+++ b/models/discordactions.js
@@ -404,7 +404,7 @@ const updateIdleUsersOnDiscord = async (dev) => {
   let allUsersHavingGroupIdle = [];
   let groupIdleRole;
   let groupIdleRoleId;
-  let allMavens = [];
+  const allMavens = [];
 
   try {
     groupIdleRole = await getGroupRole("group-idle");