From b69eaea9410777ed7761733e6fe3775df9e31ac9 Mon Sep 17 00:00:00 2001 From: anuj chhikara Date: Wed, 25 Feb 2026 01:25:42 +0530 Subject: [PATCH 1/2] refactor: remove short-circuit middleware from Discord invite route --- routes/discordactions.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/routes/discordactions.js b/routes/discordactions.js index 0f8a8cdb6..8d70a95de 100644 --- a/routes/discordactions.js +++ b/routes/discordactions.js @@ -31,7 +31,6 @@ const ROLES = require("../constants/roles"); const { Services } = require("../constants/bot"); const { verifyCronJob } = require("../middlewares/authorizeBot"); const { authorizeAndAuthenticate } = require("../middlewares/authorizeUsersAndService"); -const { disableRoute } = require("../middlewares/shortCircuit"); const router = express.Router(); router.post("/groups", authenticate, checkIsVerifiedDiscord, validateGroupRoleBody, createGroupRole); @@ -42,7 +41,7 @@ router.post("/roles", authenticate, checkIsVerifiedDiscord, validateMemberRoleBo * Short-circuit the GET method for this endpoint * Refer https://github.com/Real-Dev-Squad/todo-action-items/issues/269 for more details. */ -router.get("/invite", disableRoute, authenticate, getUserDiscordInvite); +router.get("/invite", authenticate, getUserDiscordInvite); /** * Short-circuit this POST method for this endpoint * Refer https://github.com/Real-Dev-Squad/todo-action-items/issues/269 for more details. From b51497602db47ccdf5fae30a21de30fe719484aa Mon Sep 17 00:00:00 2001 From: anuj chhikara Date: Wed, 25 Feb 2026 01:40:39 +0530 Subject: [PATCH 2/2] refactor: remove commented short-circuit middleware for Discord invite routes --- routes/discordactions.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/routes/discordactions.js b/routes/discordactions.js index 8d70a95de..ac1d2f3b7 100644 --- a/routes/discordactions.js +++ b/routes/discordactions.js @@ -37,15 +37,7 @@ router.post("/groups", authenticate, checkIsVerifiedDiscord, validateGroupRoleBo router.get("/groups", authenticate, checkIsVerifiedDiscord, validateLazyLoadingParams, getPaginatedAllGroupRoles); router.delete("/groups/:groupId", authenticate, checkIsVerifiedDiscord, authorizeRoles([SUPERUSER]), deleteGroupRole); router.post("/roles", authenticate, checkIsVerifiedDiscord, validateMemberRoleBody, addGroupRoleToMember); -/** - * Short-circuit the GET method for this endpoint - * Refer https://github.com/Real-Dev-Squad/todo-action-items/issues/269 for more details. - */ router.get("/invite", authenticate, getUserDiscordInvite); -/** - * Short-circuit this POST method for this endpoint - * Refer https://github.com/Real-Dev-Squad/todo-action-items/issues/269 for more details. - */ router.post("/invite", authenticate, checkCanGenerateDiscordLink, generateInviteForUser); router.delete("/roles", authenticate, checkIsVerifiedDiscord, deleteRole);