You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way the refresh function is written is confusing since it is used as both an initializer function AND a refresh function.
Looking at the name of the function, one would usually assume that new JSON is going to be fetched every time but actually if namespace_data is passed to it, it does not call get_json.
The way the
refresh
function is written is confusing since it is used as both an initializer function AND a refresh function.Looking at the name of the function, one would usually assume that new JSON is going to be fetched every time but actually if
namespace_data
is passed to it, it does not callget_json
.https://github.com/RedHatInsights/bonfire/blob/master/bonfire/namespaces.py#L124
Also, we are
deepcopy
even in instances wherenamespace_data
is already None, andThis should be:
The text was updated successfully, but these errors were encountered: