New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`fec build` hides away error status codes #2040

Closed

ezr-ondrej opened this issue Jul 22, 2024 · 3 comments · Fixed by #2041

Member

ezr-ondrej commented Jul 22, 2024

Building is hiding away error codes, which trips CI.

For example: https://github.com/osbuild/image-builder-frontend/actions/runs/10036303735/job/27733799568 (Build stage)
Looks green even tho it errored out.

ezr-ondrej mentioned this issue

Propagate build process status #2041

Merged

Contributor

Hyperkid123 commented Jul 22, 2024

@ezr-ondrej which version of the package do you use?

Contributor

Hyperkid123 commented Jul 22, 2024

We should probably throw a error here: https://github.com/RedHatInsights/frontend-components/blob/master/packages/config/src/bin/build-script.ts#L28

Member Author

ezr-ondrej commented Jul 22, 2024

See a PR with a proposal: #2041 :)
I think we're on the latest now.

Hyperkid123 closed this as completed in #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment