From 3147597fd093807c9e0ae5b761c0acf35ab51cab Mon Sep 17 00:00:00 2001 From: Igor Malinovskiy Date: Wed, 5 Oct 2022 17:06:23 +0200 Subject: [PATCH] Add some code tweaks --- src/app/models/key-models/bfkey.cpp | 5 ++--- src/app/models/key-models/bfkey.h | 10 ++++++++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/app/models/key-models/bfkey.cpp b/src/app/models/key-models/bfkey.cpp index 1a10e5adb..20a5685d8 100644 --- a/src/app/models/key-models/bfkey.cpp +++ b/src/app/models/key-models/bfkey.cpp @@ -44,14 +44,13 @@ void BloomFilterKeyModel::loadRows(QVariant, unsigned long, return callback(err, 0); }; - auto responseHandler = [this, callback](RedisClient::Response r, Callback) { + auto responseHandler = [this, callback](const RedisClient::Response& r, Callback) { m_rowsCache.clear(); auto value = r.value().toList(); QVariantMap row; - for (QVariantList::const_iterator item = value.cbegin(); item != value.cend(); - ++item) { + for (auto item = value.cbegin(); item != value.cend(); ++item) { auto key = item->toByteArray(); ++item; diff --git a/src/app/models/key-models/bfkey.h b/src/app/models/key-models/bfkey.h index f0e2d44d1..3392b4db2 100644 --- a/src/app/models/key-models/bfkey.h +++ b/src/app/models/key-models/bfkey.h @@ -12,10 +12,16 @@ class BloomFilterKeyModel : public KeyModel { QVariant getData(int rowIndex, int dataRole) override; void addRow(const QVariantMap&, Callback c) override; + virtual void updateRow(int, const QVariantMap&, - Callback) override {} + Callback) override { + // NOTE(u_glide): BF/CF is read-only + } void loadRows(QVariant, unsigned long, LoadRowsCallback callback) override; - void removeRow(int, Callback) override {} + + void removeRow(int, Callback) override { + // NOTE(u_glide): BF/CF is read-only + } virtual unsigned long rowsCount() override { return m_rowCount; }