From f82b680142bc9ae9e0e31685fdd325247255d1d0 Mon Sep 17 00:00:00 2001 From: "Herholz, Sebastian" Date: Tue, 17 Sep 2024 10:37:57 +0200 Subject: [PATCH] [coverity] Fixing some coverity warnings --- openpgl/data/SampleContainerInternal.h | 3 +++ openpgl/imagespace/Denoiser.h | 4 ++++ openpgl/imagespace/ImageSpaceGuidingBuffer.h | 10 +++++++++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/openpgl/data/SampleContainerInternal.h b/openpgl/data/SampleContainerInternal.h index 80b9d6a..8d4a3a1 100644 --- a/openpgl/data/SampleContainerInternal.h +++ b/openpgl/data/SampleContainerInternal.h @@ -128,6 +128,9 @@ struct ContainerInternal using value_type = Type; ContainerInternal() = default; + + ContainerInternal(const ContainerInternal& cont) = delete; + ~ContainerInternal() { delete[] m_data; diff --git a/openpgl/imagespace/Denoiser.h b/openpgl/imagespace/Denoiser.h index c3fc4c7..8a9f0bf 100644 --- a/openpgl/imagespace/Denoiser.h +++ b/openpgl/imagespace/Denoiser.h @@ -64,6 +64,10 @@ struct Denoiser oidnScalarFilter.commit(); } + Denoiser(const Denoiser& denoiser) = delete; + + Denoiser & operator=(const Denoiser&) = delete; + void denoise(pgl_vec3f *rgb, pgl_vec3f *n, pgl_vec3f *albedo, pgl_vec3f *result) { const std::size_t numPixels = m_resolution.x * m_resolution.y; diff --git a/openpgl/imagespace/ImageSpaceGuidingBuffer.h b/openpgl/imagespace/ImageSpaceGuidingBuffer.h index 65f4c5c..9ff1c84 100644 --- a/openpgl/imagespace/ImageSpaceGuidingBuffer.h +++ b/openpgl/imagespace/ImageSpaceGuidingBuffer.h @@ -45,6 +45,10 @@ struct ImageSpaceGuidingBuffer filteredSecondMoment = new pgl_vec3f[numPixels]; } + Buffers(const Buffers& buffer) = delete; + + Buffers & operator=(const Buffers&) = delete; + ~Buffers() { delete[] contribution; @@ -101,6 +105,10 @@ struct ImageSpaceGuidingBuffer m_ready = false; } + ImageSpaceGuidingBuffer(const ImageSpaceGuidingBuffer& isgbuffer) = delete; + + ImageSpaceGuidingBuffer & operator=(const ImageSpaceGuidingBuffer&) = delete; + ImageSpaceGuidingBuffer(const std::string &fileName) { EXRVersion exrVersion; @@ -484,7 +492,7 @@ struct ImageSpaceGuidingBuffer private: bool m_ready{false}; bool m_useSecondMoment{false}; - pgl_point2i m_resolution; + pgl_point2i m_resolution {0, 0}; Denoiser *m_denoiser{nullptr}; Buffers *m_contributionEstimateBuffers{nullptr};