Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password login fallback does not work #606

Open
asmacdo opened this issue Feb 15, 2023 · 1 comment
Open

Password login fallback does not work #606

asmacdo opened this issue Feb 15, 2023 · 1 comment

Comments

@asmacdo
Copy link
Member

asmacdo commented Feb 15, 2023

Summary

When creating an ssh resource for Dartmouth's Discovery cluster, (which does not accept ssh-keys) there is no password parameter. However, the code looks like it is supposed to try a password if there is an AuthenticationException:

https://github.com/ReproNim/reproman/blob/master/reproman/resource/ssh.py#L112

Reproducer

reproman create -t ssh discovery -b user=myusername -b host=discovery.dartmouth.edu

Actual Result
However, with discovery, there is no such AuthenticationException. Instead we get a socket.gaierror: (-2, 'Name or service not known')

Option 1

We could s/AuthenticationException/Exception/ to make the fallback work, but this is not ideal. Many clusters are set up to block users who attempt and fail to login a certain number of times.

Option 2

IMO the better solution would be to add a password backend-parameter to the resources.ssh

@yarikoptic wdyt?

@asmacdo
Copy link
Member Author

asmacdo commented Feb 15, 2023

Also, while I think passing a password should work, it would be better to encourage users to authenticate with gssapi because the password used here should be treated very carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant