Merge branch 'release-1.0.beta10.2' into dev-1.0-releases

Conflicts:
	ChangeLog.md
	src/install.rdf

Author: myrdd

ChangeLog.md

@@ -3,6 +3,10 @@
 Note: ChangeLogs for the source code and unit tests, both not relevant for
       users, you can find in the dedicated subdirectories.
 
+#### Version 1.0.beta10.2 (bugfix)
+* The add-on did not start on the latest Firefox Nightly,
+  version 44.0a1 (#719).
+
 #### Version 1.0.beta10.1-signed
 * The add-on is now signed by Mozilla. (#701) There's no change in
   functionality, and no bugs have been fixed.

requirements.txt

@@ -1,2 +1,2 @@
 -e git+https://github.com/mozilla/firefox-ui-tests.git#egg=firefox-ui-tests
-mozrunner >= 6.2
+mozrunner >= 6.9

src/content/lib/policy-manager.alias-functions.js

@@ -22,7 +22,7 @@
  */
 
 
-let PolicyManager = (function(self) {
+PolicyManager = (function(self) {
 
   self.addAllowRule = self.addRule.bind(this, C.RULE_ACTION_ALLOW);
   self.addTemporaryAllowRule = self.addTemporaryRule.bind(this,

src/content/lib/policy-manager.jsm

@@ -79,7 +79,7 @@ function notifyRulesChanged() {
  * Provides a simplified interface to handling multiple
  * rulesets, checking requests against multiple rulesets, etc.
  */
-let PolicyManager = (function(self) {
+var PolicyManager = (function(self) {
 
 
   let userRulesets = {};

src/content/lib/request-processor.compat.js

@@ -32,7 +32,7 @@ ScriptLoader.importModules([
 
 
 
-let RequestProcessor = (function(self) {
+RequestProcessor = (function(self) {
   let internal = Utils.moduleInternal(self);
 
 

src/content/lib/request-processor.jsm

@@ -56,7 +56,7 @@ ScriptLoader.defineLazyModuleGetters({
 
 
 
-let RequestProcessor = (function(self) {
+var RequestProcessor = (function(self) {
   let internal = Utils.moduleInternal(self);
 
 

src/content/lib/request-processor.redirects.js

@@ -41,7 +41,7 @@ ScriptLoader.importModules([
 
 
 
-let RequestProcessor = (function(self) {
+RequestProcessor = (function(self) {
   let internal = Utils.moduleInternal(self);
 
 
@@ -138,6 +138,7 @@ let RequestProcessor = (function(self) {
       return result;
     }
 
+    // fixme: "//example.com/path" is also a valid relative URL
     if (destURI[0] && destURI[0] == '/'
         || destURI.indexOf(":") == -1) {
       // Redirect is to a relative url.
@@ -424,6 +425,8 @@ let RequestProcessor = (function(self) {
     let originString = httpResponse.originURI.specIgnoringRef;
 
     // Allow redirects of requests from privileged code.
+    // Fixme: should the check instead be ' === false' in case the
+    //        return value is `null`? See also #18.
     if (!isContentRequest(httpResponse)) {
       // However, favicon requests that are redirected appear as non-content
       // requests. So, check if the original request was for a favicon.

src/content/main/window-manager-toolbarbutton.js

@@ -37,7 +37,7 @@ if (Info.isAustralis) {
 
 
 
-let rpWindowManager = (function(self) {
+rpWindowManager = (function(self) {
 
   let isAustralis = Info.isAustralis;
 

src/content/main/window-manager.jsm

@@ -26,7 +26,7 @@ let EXPORTED_SYMBOLS = ["rpWindowManager"];
 let globalScope = this;
 
 
-let rpWindowManager = (function(self) {
+var rpWindowManager = (function(self) {
 
   const Ci = Components.interfaces;
   const Cc = Components.classes;

src/content/main/window-manager.listener.js

@@ -21,7 +21,7 @@
  * ***** END LICENSE BLOCK *****
  */
 
-let WindowListener = (function() {
+WindowListener = (function() {
   let self = {};
 
   let nextWinID = 0;