Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note backwards compatibility issue on finding root metadata descriptor algorithm #362

Open
stain opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@stain
Copy link
Contributor

stain commented Oct 4, 2024

As raised by @Pfeil in #253 there may be a backward incompatibility from 1.2 if reading 1.0 crates following the algorithm in https://www.researchobject.org/ro-crate/specification/1.2-DRAFT/root-data-entity.html#finding-the-root-data-entity

1.0 crates would have the metadata descriptor as ro-crate-metadata.jsonld https://www.researchobject.org/ro-crate/specification/1.0/index.html#ro-crate-metadata-file-ro-crate-metadatajsonld and so would not match the 1.2 algorithm's search for ro-crate-metadata.json

I am not sure if this would be considered breaking semantic minor version rules https://semver.org/

The opposite -- loading a 1.2 crate with 1.1 algorithm, should however work fine as we have not changed the conformsTo URI prefix

Perhaps the simplest is to suggest loading with 1.1 algorithm if the 1.2 one fails?

@stain stain added the bug Something isn't working label Oct 4, 2024
@stain stain added this to the RO-Crate 1.2 milestone Oct 4, 2024
@stain stain mentioned this issue Oct 4, 2024
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant