Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deleted field in Reports to resolved #1638

Open
pixeldesu opened this issue Feb 28, 2024 · 2 comments
Open

Change deleted field in Reports to resolved #1638

pixeldesu opened this issue Feb 28, 2024 · 2 comments
Labels
good first issue First tasks that can be approached without much knowledge of the project refactor Rework of an existing piece of code or functionality

Comments

@pixeldesu
Copy link
Member

We don't even have soft deletes (yet), so having a field like this technically doesn't make sense. What is more appropriate in the context of Reports is a resolved field.
@pixeldesu pixeldesu added refactor Rework of an existing piece of code or functionality good first issue First tasks that can be approached without much knowledge of the project labels Feb 28, 2024
@ankiiisharma
Copy link

ankiiisharma commented Feb 28, 2024 •
edited
Loading

hey @pixeldesu , can you please elaborate this more ? i would love to work on this. thanks

@pixeldesu
Copy link
Member Author

@ankiiisharma Reports have a deleted database field (as you can find here: https://github.com/Retrospring/retrospring/blob/main/db/schema.rb#L174).

Because the field isn't really for a report being deleted but rather being resolved, the field should be renamed to resolved with a migration, and of course, all usages of the deleted field in Ruby code should be adjusted to resolved then as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue First tasks that can be approached without much knowledge of the project refactor Rework of an existing piece of code or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixeldesu @ankiiisharma