-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are you aware of https://github.com/dims/etcd3-gateway ? #112
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
this repo supports python2 and python3 with asyncio and stateful utils with human friendly api |
Thanks. I think etcd3-gateway also supports python2 and python3, but maybe not asyncio. |
yeah, it does support python2 |
etcd3-gateway does not support user/pass authentication. We are replacing with etcd3-py |
FWIW, we implemented user/pass authentication by subclassing the Etcd3Client class, as you can see here: https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/etcdv3.py#L388-L472 |
@neiljerram that is a simple solution, I liked it. Is there a reason it was not upstreamed? |
@heitorPB Ah, good question! I don't recall thinking about this carefully at the time, but I guess the thought in my mind was that the solution might not work for all possible uses of Etcd3Client. As the commenting says, I was comfortable that it works in all the cases that Calico (my project) needs - but it's possible that there are other cases not covered. Nevertheless, I think it's right to try upstreaming, and then the discussion can discuss that - so will plan to do this shortly. |
I'd be happy to help you if you need! I created an issue on their bugtracker with this request: https://bugs.launchpad.net/python-etcd3gw/+bug/1970750 |
How would you say etcd3-py compares against etcd3-gateway? Could you work together instead of apparently duplicating effort?
The text was updated successfully, but these errors were encountered: