forked from gnutls/nettle
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
11536 lines (8128 loc) · 384 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2019-02-06 Niels Möller <nisse@lysator.liu.se>
* gosthash94.h (struct gosthash94_ctx): Move block buffer last in
struct.
* md2.h (struct md2_ctx): Likewise.
* md4.h (struct md4_ctx): Likewise.
* md5.h (struct md5_ctx): Likewise.
* ripemd160.h (struct ripemd160_ctx): Likewise.
* sha1.h (struct sha1_ctx): Likewise.
* sha2.h (struct sha256_ctx, struct sha512_ctx): Likewise.
2019-01-19 Niels Möller <nisse@lysator.liu.se>
* examples/Makefile.in (TARGETS): Delete eratosthenes, left over
from earlier change.
* fat-arm.c: Fix declarations of chacha_core functions.
From Yuriy M. Kaminskiy:
* fat-setup.h (chacha_core_func): New typedef.
* fat-arm.c (fat_init): Enable choice between
_nettle_chacha_core_c and _nettle_chacha_core_neon.
* configure.ac (asm_nettle_optional_list): Add
chacha-core-internal-2.asm.
* chacha-core-internal.c: Enable fat build with C and asm version.
* arm/fat/chacha-core-internal-2.asm: New file.
2019-01-12 Niels Möller <nisse@lysator.liu.se>
* examples/eratosthenes.c: Deleted program.
* examples/Makefile.in: Delete rule to build and distribute it.
2019-01-10 Niels Möller <nisse@lysator.liu.se>
* testsuite/rsa-compute-root-test.c (test_one): Use %u and
corresponding cast, when printing bit sizes.
2019-01-09 Niels Möller <nisse@lysator.liu.se>
* examples/nettle-benchmark.c (GET_CYCLE_COUNTER): Add volatile to
inline asm.
2019-01-08 Niels Möller <nisse@lysator.liu.se>
* sha512-compress.c: Add missing include of sha2-internal.h.
2019-01-06 Niels Möller <nisse@lysator.liu.se>
* testsuite/rsa-compute-root-test.c (generate_keypair): Fix assert
call with side-effects.
2019-01-06 Niels Möller <nisse@lysator.liu.se>
* nettle-types.h: Don't use nettle-stdint.h, include <stdint.h>
directly.
* nettle-write.h: Likewise.
* configure.ac: Delete use of AX_CREATE_STDINT_H.
* aclocal.m4 (AX_CREATE_STDINT_H): Delete.
* Makefile.in (INSTALL_HEADERS, distclean-here): Delete mention of
nettle-stdint.h.
2018-12-26 Niels Möller <nisse@lysator.liu.se>
* examples/hogweed-benchmark.c (make_openssl_rsa_ctx): New helper
function. Call openssl's RSA_generate_key_ex rather then the
deprecated RSA_generate_key.
(bench_openssl_rsa_init, bench_openssl_rsa_tr_init): Use it.
* eccdata.c (ecc_pippenger_precompute): Check that table size is
at least 2. Intended to silence warning from the clang static
analyzer.
* configure.ac: Bump package version to 3.5.
(LIBNETTLE_MAJOR): Bump major number, now 7.
(LIBHOGWEED_MAJOR): Bump major number, now 5.
(LIBNETTLE_MINOR, LIBHOGWEED_MINOR): Reset to zero.
* pkcs1-internal.h: New header file, moved declarations of
_pkcs1_sec_decrypt and _pkcs1_sec_decrypt_variable here.
* rsa-internal.h: ... old location.
* Makefile.in (DISTFILES): Added pkcs1-internal.h.
* pkcs1-decrypt.c: Include new file.
* pkcs1-sec-decrypt.c: Likewise.
* rsa-decrypt-tr.c: Likewise.
* rsa-sec-decrypt.c: Likewise.
* testsuite/pkcs1-sec-decrypt-test.c: Likewise.
* tools/nettle-pbkdf2.c: Add #define _GNU_SOURCE, needed for
strdup with gcc -std=c89.
* testsuite/ed25519-test.c: Add #define _GNU_SOURCE, needed for
getline with gcc -std=c89.
* rsa-sign-tr.c (sec_equal): Fix accidental use of C99 for loop.
Reported by Andreas Gustafsson.
* testsuite/rsa-sec-decrypt-test.c (test_main): Likewise.
2018-12-04 Niels Möller <nisse@lysator.liu.se>
* Released nettle-3.4.1.
2018-11-28 Niels Möller <nisse@lysator.liu.se>
* configure.ac: Update GMP check. Check for the function
mpn_sec_div_r, available since GMP-6.0.0.
* testsuite/rsa-encrypt-test.c (test_main): Fix allocation of
decrypted storage. Update test of rsa_decrypt, to allow clobbering
of all of the passed in message area.
* pkcs1-decrypt.c (pkcs1_decrypt): Rewrite as a wrapper around
_pkcs1_sec_decrypt_variable. Improves side-channel silence of the
only caller, rsa_decrypt.
* Makefile.in (DISTFILES): Add rsa-internal.h, needed for make
dist. Patch from Simo Sorce.
* rsa-internal.h: Add include of rsa.h.
2018-11-27 Niels Möller <nisse@lysator.liu.se>
* rsa-sec-compute-root.c (sec_mul, sec_mod_mul, sec_powm): New
local helper functions, with their own itch functions.
(_rsa_sec_compute_root_itch, _rsa_sec_compute_root): Rewrote to
use helpers, for clarity.
2018-11-26 Niels Möller <nisse@lysator.liu.se>
* testsuite/rsa-compute-root-test.c (generate_keypair): Simplify
selection of psize and qsize, and fix so that qsize is used.
(test_main): Add outer loop, to test with more than one key.
Deallocate storage before exiting.
2018-11-25 Niels Möller <nisse@lysator.liu.se>
* testsuite/rsa-compute-root-test.c: Renamed, from ...
* testsuite/rsa-sec-compute-root-test.c: ... old name.
* rsa.h (rsa_sec_compute_root_tr): Deleted declaration, moved to ...
* rsa-internal.h (_rsa_sec_compute_root_tr): ... new location.
* rsa-sign-tr.c (_rsa_sec_compute_root_tr): Renamed, from...
(rsa_sec_compute_root_tr): ... old name. Updated callers.
(cnd_mpn_zero): Use a volatile-declared mask variable.
* testsuite/testutils.c (mpz_urandomb) [NETTLE_USE_MINI_GMP]: Fix
masking of most significant bits.
* rsa-decrypt-tr.c (rsa_decrypt_tr): Use
NETTLE_OCTET_SIZE_TO_LIMB_SIZE.
* testsuite/rsa-sec-decrypt-test.c (rsa_decrypt_for_test): Tweak
valgrind marking, and document potential leakage of lowest and
highest bits of p and q.
* rsa-sec-compute-root.c (_rsa_sec_compute_root): Avoid calls to
mpz_sizeinbase, since that potentially leaks most significant bits
of private key parameters a and b.
* testsuite/pkcs1-sec-decrypt-test.c (pkcs1_decrypt_for_test): Fix
valgrind marking of return value.
Merged below changes from Simo Sorce, to make RSA private key
operations side-channel silent.
2018-11-08 Simo Sorce <simo@redhat.com>
* rsa-sign.c (rsa_compute_root) [!NETTLE_USE_MINI_GMP]: Use
_rsa_sec_compute_root.
* testsuite/rsa-sec-compute-root-test.c: Add more tests for new
side-channel silent functions.
* rsa-sign.c (rsa_private_key_prepare): Check that qn + cn >= pn,
since that is required for one of the GMP calls in
_rsa_sec_compute_root.
* rsa-decrypt-tr.c: Switch to use side-channel silent functions.
* pkcs1-sec-decrypt.c (_pkcs1_sec_decrypt_variable): New private
function. Variable size version for backwards compatibility.
* testsuite/rsa-sec-decrypt-test.c: Adds more tests.
* rsa-sec-decrypt.c (rsa_sec_decrypt): New function.
Fixed length side-channel silent version of rsa-decrypt.
* testsuite/rsa-encrypt-test.c: add tests for the new fucntion.
* testsuite/pkcs1-sec-decrypt-test.c: Adds tests for
_pkcs1_sec_decrypt.
* gmp-glue.c (mpn_get_base256): New function.
* pkcs1-sec-decrypt.c (_pkcs1_sec_decrypt): New private function.
Fixed length side-channel silent version of pkcs1-decrypt.
* cnd-memcpy.c (cnd_memcpy): New function.
* memops.h: Declare it.
* testsuite/cnd-memcpy-test.c: New test case.
* rsa-sign-tr.c (rsa_sec_compute_root_tr): New function that uses
_rsa_sec_compute_root, as well as side-channel silent RSA
blinding.
(rsa_compute_root_tr) Rewritten as a wrapper around
rsa_sec_compute_root_tr.
(rsa_sec_blind, rsa_sec_unblind, sec_equal, rsa_sec_check_root)
(cnd_mpn_zero): New helper functions.
(rsa_sec_compute_root_tr) [NETTLE_USE_MINI_GMP]: Defined as a not
side-channel silent wrapper around rsa_compute_root_tr, and the
latter function left unchanged.
* rsa-sec-compute-root.c (_rsa_sec_compute_root_itch)
(_rsa_sec_compute_root): New file, new private functions.
Side-channel silent version of rsa_compute_root.
* rsa-internal.h: New header file with declarations.
* gmp-glue.h (NETTLE_OCTET_SIZE_TO_LIMB_SIZE): New macro.
2018-11-24 Niels Möller <nisse@lysator.liu.se>
* configure.ac: Bump package version to 3.4.1.
(LIBNETTLE_MINOR): Bump library version to 6.5.
(LIBHOGWEED_MINOR): Bump library version to 4.5.
2018-11-17 Niels Möller <nisse@lysator.liu.se>
* examples/hogweed-benchmark.c (bench_rsa_verify)
(bench_openssl_rsa_tr_init): New functions.
(alg_list): Benchmark timing-resistant RSA functions, i.e.,
including RSA blinding.
(main): Increase width of first column, here and in other
printouts.
2018-10-10 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
* ctr16.c (_ctr_crypt16): Bugfix for the src == dst case, when
processing more than on full block of size CTR_BUFFER_LIMIT, src
and dst arguments to memxor3 were not properly updated.
2018-10-10 Niels Möller <nisse@lysator.liu.se>
* aes-set-encrypt-key.c: Add missing include of stdlib.h.
* des-compat.c: Likewise.
2018-09-13 Niels Möller <nisse@lysator.liu.se>
* rsa-keygen.c (rsa_generate_keypair): Delete unlikely and
redundant check for p == q.
2018-08-09 Niels Möller <nisse@lysator.liu.se>
* rsa-internal.h (_rsa_blind, _rsa_unblind): Mark with
_NETTLE_ATTRIBUTE_DEPRECATED.
* nettle-types.h (_NETTLE_ATTRIBUTE_PURE)
(_NETTLE_ATTRIBUTE_DEPRECATED): New macros, for gcc and
lookalikes.
* ecc-curve.h: Include nettle-types.h, and use
_NETTLE_ATTRIBUTE_PURE instead of local definition.
* nettle-meta.h: Use _NETTLE_ATTRIBUTE_PURE, instead of explicit
#ifdefs.
* aes.h: Mark functions using struct aes_ctx interface as
deprecated. Add #undef _NETTLE_ATTRIBUTE_DEPRECATED in files where
the functions are implemented or tested.
* gcm.h: Similarly mark functions using gcm_aes_ctx as deprecated.
* nettle-internal.c (des_set_key_wrapper, des3_set_key_wrapper)
(blowfish128_set_key_wrapper): Wrapper functions, to avoid cast
between incompatible function types (which gcc-8 warns about).
Wrappers are expected to compile to a single jmp instruction.
* des-compat.c (des_compat_des3_encrypt)
(des_compat_des3_decrypt): Change length argument type to size_t.
2018-08-08 Niels Möller <nisse@lysator.liu.se>
* nettle.texinfo (Compatibility): New section on ABI and API
compatibility.
2018-07-25 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
* examples/nettle-benchmark.c: Add benchmarking for HMAC functions.
2018-07-13 Niels Möller <nisse@lysator.liu.se>
* examples/eratosthenes.c (vector_alloc): Add assert related to
overflow in the size calculation. Fixes a corner case identified
by static analysis.
(vector_init): Analogous assert.
2018-07-12 Niels Möller <nisse@lysator.liu.se>
* examples/eratosthenes.c (main): Don't allocate bitmap storage
for limit == 2 (early exit), closing memory leak at exit.
(main): Fix handling of short -q option.
* eccdata.c (output_curve): Replace mpz_init_set_ui by mpz_set_ui,
to fix memory leak.
(ecc_curve_clear): New function.
(main): Call it, to deallocate storage before exit.
2018-07-08 Niels Möller <nisse@lysator.liu.se>
* fat-x86_64.c (fat_init): Fix setup for nettle_sha1_compress.
* x86_64/fat/sha1-compress.asm: Add leading underscore to symbol name.
* x86_64/fat/sha1-compress-2.asm: Likewise.
2018-07-07 Niels Möller <nisse@lysator.liu.se>
From Nikos Mavrogiannopoulos.
* sha1-compress.c (nettle_sha1_compress): Renamed, and promoted to
public function, since there's known appliation usage (filezilla).
* sha1.h (_nettle_sha1_compress): Old name, now a preprocessor
alias for the new name.
* md5-compress.c (nettle_md5_compress): Similarly renamed (used by
sogo).
* md5.h (_nettle_md5_compress): Old name,, now a preprocessor
alias for the new name.
* chacha-internal.h, dsa-internal.h, eddsa-internal.h:
* hogweed-internal.h, ripemd160-internal.h, rsa-internal.h:
* salsa20-internal.h, sha2-internal.h, sha3-internal.h:
* umac-internal.h: Internal declarations moved to new header
files, which are not installed..
* Makefile.in (DISTFILES): Added above files.
* libnettle.map.in: Use a different symbol version for _nettle_*
symbols, depending on the minor release. This marks these symbols
explicitly not part of the public Nettle ABI.
* libhogweed.map.in: Analogous change.
2018-06-17 Niels Möller <nisse@lysator.liu.se>
* aclocal.m4 (NETTLE_CHECK_IFUNC): Fix quoting. Patch contributed
by Dmitry Eremin-Solenikov.
* testsuite/symbols-test: Exclude ____chkstk_darwin symbols,
produced by Apple's Xcode 10 compiler. Patch contributed by
Dominyk Tiller.
2018-03-25 Niels Möller <nisse@lysator.liu.se>
From Michael Weiser.
* configure.ac (ASM_WORDS_BIGENDIAN): New substution, set from AC_C_BIGENDIAN.
* config.m4.in: Use it to set WORDS_BIGENDIAN.
* asm.m4 (IF_BE, IF_LE): New macros.
* arm/memxor.asm: Support big-endian ARM.
* arm/memxor3.asm: Likewise.
* arm/neon/chacha-core-internal.asm: Likewise.
* arm/neon/salsa20-core-internal.asm: Likewise.
* arm/neon/umac-nh.asm: Likewise.
* arm/v6/sha1-compress.asm: Likewise.
* arm/v6/sha256-compress.asm: Likewise.
* arm/README: Document big-endian considerations.
2018-03-17 Niels Möller <nisse@lysator.liu.se>
Discourage direct access to data symbols with non-public size.
Direct references to these symbols may result in copy-relocations
like R_X86_64_COPY, which make the symbol size leak into the ABI.
* ecc-curve.h (_nettle_secp_192r1, _nettle_secp_224r1)
(_nettle_secp_256r1, _nettle_secp_384r1, _nettle_secp_521r1): Add
leading underscore on these data symbols.
* nettle-meta.h (_nettle_ciphers, _nettle_hashes, _nettle_aeads)
(_nettle_armors): Add leading underscore on these data symbols.
Update all internal use. Macros without leading underscore remain,
and expand to access via accessor functions nettle_get_ciphers and
similar.
2018-03-10 Niels Möller <nisse@lysator.liu.se>
* eccdata.c (ecc_table_size): New helper function.
(ecc_pippenger_precompute): Display warning for poor parameters.
* eccparams.c (main): New program, to list parameter alternatives
for Pippenger's algorithm.
* Makefile.in: Tweak parameters for ecc tables.
(ecc-192.h): Change parameters from k = 7, c = 6 to k = 8, c = 6.
Reduces table size from 15 KB to 12 KB. Modest speedup, appr. 3%
for ecdsa signatures.
(ecc-224.h): Change parameters from k = 12, c = 6 to k = 16, c =
7. Table size unchanged (14 KB in 32-bit platforms, 18 KB on
64-bit platforms. Minor speedup, appr. 1% for ecdsa signatures.
(ecc-256.h): Change parameters from k = 14, c = 6 to k = 11, c =
6. Table size unchanged, 16 KB. 14% speedup for ecdsa signatures.
(ecc-384.h): Changed parameters from k = 41, c = 6 to k = 32, c =
6. Table size unchanged. 12% speedup for ecdsa signatures.
(ecc-521.h): Changed parameters from k = 56, c = 6 to k 44, c = 6.
Table size unchanged (17 KB on 32-bit platforms, 18 KB on 64-bit
platforms). 15% speedup for ecdsa signatures.
(ecc-255.h): Change parameters from k = 14, c = 6 to k = 11, c =
6. Table size unchanged, 16 KB. 24% speedup for eddsa signatures.
2018-03-14 Niels Möller <nisse@lysator.liu.se>
Merge sha256 code using the x86_64 sha_ni instructions, starting
2018-02-21.
2018-03-11 Niels Möller <nisse@lysator.liu.se>
* x86_64/fat/sha256-compress.asm: New file.
* x86_64/fat/sha256-compress-2.asm: New file.
* fat-x86_64.c (fat_init): Select plain x86_64 assembly version or
sha_ni version for sha256_compress.
2018-02-21 Niels Möller <nisse@lysator.liu.se>
* x86_64/sha_ni/sha256-compress.asm: New implementation using sha_ni
instructions.
2018-02-20 Niels Möller <nisse@lysator.liu.se>
* testsuite/cmac-test.c (test_cmac_hash): Deallocate ctx properly.
2018-02-19 Niels Möller <nisse@lysator.liu.se>
Mostly aesthetic changes. Besides indentation:
* cmac.h (struct cmac128): Rename, to cmac128_ctx.
(CMAC128_CTX): Rename first member from data to ctx.
* cmac.c: Use const void * as the type for cipher arguments.
(block_mulx): Un-inline.
(cmac128_set_key): Make a constant function local.
* testsuite/cmac-test.c: Delete local typedefs.
2018-02-19 Nikos Mavrogiannopoulos <nmav@redhat.com>
Add support for CMAC.
* cmac.h: New file.
(struct cmac128): New struct.
* cmac.c (block_mulx, cmac128_set_key, cmac128_update)
(cmac128_digest): New file, new functions.
* cmac-aes128.c (cmac_aes128_set_key, cmac_aes128_update)
(cmac_aes128_digest): New file, new functions.
* cmac-aes256.c (cmac_aes256_set_key, cmac_aes256_update)
(cmac_aes256_digest): New file, new functions.
* Makefile.in (nettle_SOURCES): Added cmac.c cmac-aes128.c cmac-aes256.c.
(HEADERS): Added cmac.h.
* testsuite/cmac-test.c: New tests.
* testsuite/Makefile.in (TS_NETTLE_SOURCES): Add cmac-test.c.
* examples/nettle-benchmark.c (time_cmac): New function.
(main): Use it.
* nettle.texinfo: Document CMAC.
2018-02-20 Niels Möller <nisse@lysator.liu.se>
* testsuite/cbc-test.c (test_cbc_bulk): Use struct
aes256_ctx, instead of the deprecated struct aes_ctx.
* testsuite/cfb-test.c (test_cfb_bulk): Likewise.
* examples/rsa-session.h (struct rsa_session): Likewise.
* examples/rsa-encrypt.c (rsa_session_set_encrypt_key)
(process_file): Use aes256_* functions.
* examples/rsa-decrypt.c (rsa_session_set_decrypt_key)
(process_file): Likewise.
2018-02-19 Niels Möller <nisse@lysator.liu.se>
* nettle-internal.h: Include sha3.h, needed for the definition of
NETTLE_MAX_HASH_CONTEXT_SIZE.
(TMP_DECL_ALIGN, TMP_ALLOC_ALIGN): New macros, to support
allocation of context structs with alignment requirements.
[!HAVE_ALLOCA]: Also use assert, rather than calling abort
directly.
* pss.c (pss_encode_mgf1, pss_verify_mgf1): Use new macros.
* pss-mgf1.c (pss_mgf1): Likewise.
2018-02-18 Niels Möller <nisse@lysator.liu.se>
* testsuite/Makefile.in (TS_NETTLE_SOURCES): Moved pss-mgf1-test.c...
(TS_HOGWEED_SOURCES): ...to here. Fixes link failure in builds
without public-key support.
2018-02-18 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
* examples/nettle-openssl.c): Move expressions with side effects
out of asserts.
2018-02-17 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
(openssl_evp_set_encrypt_key, openssl_evp_set_decrypt_key): Use
EVP_CipherInit_ex.
* examples/nettle-openssl.c (nettle_openssl_gcm_aes128)
(nettle_openssl_gcm_aes192, nettle_openssl_gcm_aes256): New aead
algorithms, for benchmarking purposes, and supporting wrapper functions.
* nettle-internal.h: Corresponding declarations.
* examples/nettle-benchmark.c (main): Include openssl's gcm aes in
benchmark.
2018-02-16 Niels Möller <nisse@lysator.liu.se>
* nettle.texinfo: Improved index entries.
(Cipher functions): Update CAST128/CAST5 docs. Inconsistencies
spotted by Henrik Rindlöw.
2018-02-10 Niels Möller <nisse@lysator.liu.se>
* configure.ac: New configure option --enable-x86-sha-ni.
2018-02-07 Niels Möller <nisse@lysator.liu.se>
* x86_64/fat/sha1-compress.asm: New file.
* x86_64/fat/sha1-compress-2.asm: New file.
* fat-x86_64.c (fat_init): Select plain x86_64 assembly version or
sha_ni version for sha1_compress.
2018-02-05 Niels Möller <nisse@lysator.liu.se>
* x86_64/sha_ni/sha1-compress.asm: New implementation using sha_ni
instructions.
* fat-x86_64.c (get_x86_features): Check for sha_ni extension.
* x86_64/fat/cpuid.asm: Clear %ecx input to cpuid instruction.
2018-02-01 Nikos Mavrogiannopoulos <nmav@redhat.com>
* gcm.c (gcm_fill): New function, for use with _ctr_crypt16.
(gcm_encrypt, gcm_decrypt): Use _ctr_crypt16. 50% speedup of
gcm_aes128, benchmarked on x86_64 with aesni instructions.
2018-02-01 Niels Möller <nisse@lysator.liu.se>
Based on a patch contributed by Nikos Mavrogiannopoulos.
* ctr16.c (_ctr_crypt16): New file, renamed and generalized
function. New function pointer argument, used to fill a block with
counter values. Use nettle_block16 * as the type for the buffer to
be filled. Always process any final and partial block, and return
no value.
* ctr.c (ctr_crypt): ... previous, replaced, function.
(ctr_fill16): Updated to new argument type.
(ctr_crypt): Return immediately after using _ctr_crypt16.
* ctr-internal.h: New file, declaring _ctr_crypt16.
(nettle_fill16_func): New function typedef.
* Makefile.in (nettle_SOURCES): Added ctr16.c.
(DISTFILES): Added ctr-internal.h.
2018-01-30 Niels Möller <nisse@lysator.liu.se>
* Makefile.in (clean-here): Don't delete desdata.stamp.
2018-01-24 Jay Foad <jay.foad@gmail.com>
* Makefile.in (TARGETS): Delete dependencies on aesdata, desdata,
twofishdata, shadata and gcmdata. They are not needed for a normal
build.
(clean-here): Explicitly delete of above files.
(desdata.stamp): New stamp target, to avoid building desdata twice
in a parallell build.
2018-01-23 Niels Möller <nisse@lysator.liu.se>
* configure.ac (asm_path): Recognize "x86", in addition to "i?86",
for 32-bit x86 processors. Reportedly needed for x86 android builds.
2018-01-20 Niels Möller <nisse@lysator.liu.se>
CFB8 support, contributed by Dmitry Eremin-Solenikov.
* cfb.c (cfb8_encrypt, cfb8_decrypt): New functions.
* cfb.h: Declare them.
(CFB8_ENCRYPT, CFB8_DECRYPT): New macros.
* testsuite/cfb-test.c: New tests for CFB8.
* nettle.texinfo (CFB and CFB8): Documentation.
2018-01-16 Niels Möller <nisse@lysator.liu.se>
* tools/pkcs1-conv.c (convert_file): Add missing break statements.
2018-01-09 Niels Möller <nisse@lysator.liu.se>
* testsuite/testutils.c (test_cipher_ctr): Test operations with
shorter sizes.
* testsuite/ctr-test.c: Additional unofficial test vectors, to
exercise carry propagation in the counter, and block size
different from 16.
2018-01-08 Niels Möller <nisse@lysator.liu.se>
* ctr.c (ctr_crypt16): New function, with optimizations specific
to 16-byte block size.
(ctr_fill16): New helper function, definition depending on
WORDS_BIGENDIAN, and little endian version requiring
HAVE_BUILTIN_BSWAP64.
(ctr_crypt): Use ctr_crypt16, when appropriate.
* nettle-types.h (union nettle_block16): Add uint64_t field.
* configure.ac: Check for __builtin_bswap64, define
HAVE_BUILTIN_BSWAP64 if available.
* ctr.c (ctr_fill): New function. Use in ctr_crypt.
* ctr.c (ctr_crypt): For in-place operation, increase max buffer
size from 4 blocks to 512 bytes, similarly to CBC and CFB.
Improves in-place aes128 CTR performance by 25% on x86_64.
* examples/nettle-benchmark.c (time_cipher): Benchmark in-place
operation separately, for cbc_decrypt and ctr_crypt.
* cbc.c (cbc_decrypt): For in-place operation (src == dst case),
eliminate use of src variable.
* cfb.c (cfb_decrypt): Likewise.
* gcm.c (gcm_crypt): Likewise, and replace one memxor3 by memxor.
2018-01-03 Niels Möller <nisse@lysator.liu.se>
* x86_64/aesni/aes-encrypt-internal.asm: Read subkeys into xmm
registers before the block loop, and completely unroll the round
loop.
* x86_64/aesni/aes-decrypt-internal.asm: Likewise.
2017-11-19 Niels Möller <nisse@lysator.liu.se>
* Released nettle-3.4.
2017-11-12 Niels Möller <nisse@lysator.liu.se>
* configure.ac: Update check of GMP_NUMB_BITS declaration in
assembly files. Was broken by rename of configure variable
GMP_NUMB_BITS --> NUMB_BITS.
2017-11-11 Niels Möller <nisse@lysator.liu.se>
* nettle.texinfo: Document nettle_get_hashes, nettle_get_ciphers
and nettle_get_aeads, and replace nettle_secp_256r1 by
nettle_get_secp_256r1. Update version numbers. Delete ancient
setting of ispell-skip-region-alist as an emacs file-local
variable.
2017-11-08 Niels Möller <nisse@lysator.liu.se>
* ecc-curve.h (nettle_secp_192r1, nettle_secp_224r1)
(nettle_secp_256r1, nettle_secp_384r1, nettle_secp_521r1): Delete
macro wrappers, partially reverting below 2017-04-09 change. They
didn't work at all for applications that only see a forward
declaration of struct ecc_curve. Instead, we will have to make an
ABI and API break and delete these symbols, when the size of
struct ecc_curve is increased.
2017-11-05 Niels Möller <nisse@lysator.liu.se>
* configure.ac Bump package version to 3.4.
(LIBNETTLE_MINOR): Bump library version to 6.4.
(LIBHOGWEED_MINOR): Bump library version to 4.4.
2017-10-23 Niels Möller <nisse@lysator.liu.se>
* examples/Makefile.in (check): Also set DYLD_LIBRARY_PATH in the
environment, to support Mac OSX shared libraries.
* testsuite/Makefile.in (LD_LIBRARY_PATH): Likewise.
2017-10-23 Niels Möller <nisse@lysator.liu.se>
Merge API fixes, starting at 2017-01-12.
2017-04-09 Niels Möller <nisse@lysator.liu.se>
* ecc-curve.h (nettle_get_secp_192r1, nettle_get_secp_224r1)
(nettle_get_secp_256r1, nettle_get_secp_384r1)
(nettle_get_secp_521r1): New functions, returning a pointer to
corresponding structure.
(nettle_secp_192r1, nettle_secp_224r1, nettle_secp_256r1)
(nettle_secp_384r1, nettle_secp_521r1): Redefined as macros,
calling the corresponding function.
* nettle-meta.h (nettle_ciphers, nettle_aeads, nettle_armors): New
macros, analogous to below change to nettle_hashes.
* nettle-meta-ciphers.c (nettle_get_ciphers): New function.
* nettle-meta-aeads.c (nettle_get_aeads): New function.
* nettle-meta-armors.c (nettle_get_armors): New function.
2017-01-12 Niels Möller <nisse@lysator.liu.se>
* tools/nettle-hash.c (find_algorithm): Deleted function.
(main): Replaced by call to nettle_lookup_hash.
* testsuite/meta-hash-test.c (test_main): Use nettle_lookup_hash.
* nettle-meta.h (nettle_hashes): New macro, expanding to a call to
nettle_get_hashes. Direct access to the array causes the array
size to leak into the ABI, since a plain un-relocatable executable
linking with libnettle.so gets copy relocations for any referenced
data items in the shared library.
* nettle-meta-hashes.c (nettle_get_hashes): New function.
2017-10-16 Niels Möller <nisse@lysator.liu.se>
CFB support, contributed by Dmitry Eremin-Solenikov.
* cfb.c (cfb_encrypt, cfb_decrypt): New file, new functions.
* cfb.h: New header file.
(CFB_CTX, CFB_SET_IV, CFB_ENCRYPT, CFB_DECRYPT): New macros.
* Makefile.in (nettle_SOURCES): Add cfb.c.
(HEADERS): Add cfb.h.
* testsuite/cfb-test.c: New test case.
* testsuite/testutils.c (test_cipher_cfb): New function.
* nettle.texinfo (CFB): Documentation.
2017-10-16 Niels Möller <nisse@lysator.liu.se>
* aclocal.m4 (GMP_PROG_CC_FOR_BUILD): Add -g when compiling with
gcc.
2017-09-27 Niels Möller <nisse@lysator.liu.se>
Merged armor-signedness branch, starting 2017-08-27.
2017-09-24 Niels Möller <nisse@lysator.liu.se>
* tools/pkcs1-conv.c (base64_decode_in_place): New helper
function.
(decode_base64): Use it.
* sexp-transport-format.c (base64_encode_in_place): New helper
function.
(sexp_transport_vformat): Use it.
* testsuite/base64-test.c (test_fuzz_once): Update to use char
type where appropriate.
(test_main): Use helper functions base64_encode_in_place and
base64_decode_in_place (copied to this file).
* testsuite/testutils.c (tstring_data): Use uint8_t for data
argument.
* testsuite/testutils.h (SDATA): Use US macro to cast data
argument.
2017-08-27 Niels Möller <nisse@lysator.liu.se>
* base64-encode.c (base64_encode_raw, base64_encode_group)
(base64_encode_single, base64_encode_update)
(base64_encode_final): Change type of destination to char *.
* base16-encode.c (base16_encode_single, base16_encode_update):
Likewise.
* base64-decode.c (base64_decode_single, base64_decode_update):
Change type of source argument to const char *. Update (almost)
all callers.
* base16-decode.c (base16_decode_single, base16_decode_update):
Likewise.
* nettle-types.h (nettle_armor_encode_update_func)
(nettle_armor_encode_final_func, nettle_armor_decode_update_func):
Corresponding updates to typedefs.
2017-09-14 Niels Möller <nisse@lysator.liu.se>
* hkdf.c: Delete unneeded includes. Use Nettle licensing notice.
* hkdf.h: Include only nettle-types.h, not nettle-meta.h.
* ecc-mod.c (ecc_mod): Workaround to silence a false positive from
the clang static analyzer.
2017-09-12 Niels Möller <nisse@lysator.liu.se>
* testsuite/testutils.h (mpn_zero_p): Avoid redefining mpn_zero_p
when building with mini-gmp. Since the mini-gmp update, this
function is defined by mini-gmp, causing link errors if nettle is
configured with --enable-mini-gmp --disable-shared. Reported by
Tim Rühsen.
2017-09-09 Daiki Ueno <dueno@redhat.com>
* testsuite/ecc-mul-g-test.c (test_main): Fixed mpn_cmp call.
* testsuite/ecc-mul-a-test.c (test_main): Likewise.
* eccdata.c (ecc_point_out): Write to given stream, instead of
stderr.
* eccdata.c (output_curve): In curve448, the bit size of the order
is slightly smaller than the one of p's. Adjust ecc_Bmodq_shifted
accordingly.
2017-09-09 Niels Möller <nisse@lysator.liu.se>
* mini-gmp.c: Updated mini-gmp from the gmp repository, latest
change from 2017-07-23.
* mini-gmp.h: Likewise.
2017-09-06 Niels Möller <nisse@lysator.liu.se>
* hkdf.c (hkdf_expand): Eliminate a (signed) ssize_t variable, use
break rather than return at loop termination.
2017-09-06 Niels Möller <nisse@lysator.liu.se>
HKDF implementation, contributed by Nikos Mavrogiannopoulos.
* hkdf.c (hkdf_extract, hkdf_expand): New file, new functions.
* hkdf.h: New file.
* Makefile.in (nettle_SOURCES): Add hkdf.c.
(HEADERS): Add hkdf.h.
* testsuite/hkdf-test.c: Tests for hkdf-sha256 and hkdf-sha1.
* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added hkdf-test.c.
* nettle.texinfo (Key derivation functions): Document HKDF.
2017-09-04 Andreas Schneider <asn@samba.org>
* fat-arm.c: Add missing define for _GNU_SOURCE.
2017-08-27 Niels Möller <nisse@lysator.liu.se>
* configure.ac (GMP_NUMB_BITS): Set to dummy value "n/a" in
mini-gmp builds.
(NUMB_BITS): New substituted variable which always holds the
configured value.
* Makefile.in (GMP_NUMB_BITS): Renamed variable...
(NUMB_BITS): ...new name
* config.make.in: Update corresponding substitution.
2017-08-26 Niels Möller <nisse@lysator.liu.se>
* ecc-mod-inv.c (ecc_mod_inv): Add missing assert. Fixes a
"dead increment" warning from the clang static analyzer.
2017-08-26 Niels Möller <nisse@lysator.liu.se>
* examples/nettle-openssl.c (struct openssl_cipher_ctx): New
struct. Use everywhere, instead of typing EVP_CIPHER_CTX pointers
directly.
* configure.ac: Update openssl-related tests. Checks for
cipher-specific headers are replaced by a check for openssl/evp.h,
and the check for the BF_ecb_encrypt function is replaced by a
check for EVP_CIPHER_CTX_new.
2017-08-03 Daniel P. Berrange <berrange@redhat.com>
* examples/nettle-openssl.c: Rewritten to use openssl's EVP APIs.
The older cipher-specific functions always use openssl's generic
software implementation, while the EVP functions enables
platform-specific code, e.g., using the x86 AES-NI instructions.
(nettle_openssl_init): New function.
2017-07-18 Niels Möller <nisse@lysator.liu.se>
* ecc-add-eh.c (ecc_add_eh): Fix in-place operation by reordering
two multiplies. Previously, in-place operation resulted in an
invalid call to mpn_mul with overlapping operands. Reported by
Sergei Trofimovich.
2017-06-09 Niels Möller <nisse@lysator.liu.se>
* pss.c (pss_verify_mgf1): Check for m being too large, fixing an
assertion failure for certain invalid signatures. Based on a patch
contributed by Daiki Ueno.
* testsuite/rsa-pss-sign-tr-test.c (test_main): Add test case
contributed by Daiki Ueno. Problem originally found by oss-fuzz,
see https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2132.
That problem report is currently embargoed, but will hopefully be
public in a month or two.
2017-05-23 Niels Möller <nisse@lysator.liu.se>
Rework the previous change, which had the unintended effect of
always regenerating .test-rules.make after ./configure is run.
* testsuite/Makefile.in (test-rules.stamp): New stamp file target,
depend on Makefile.in, and run $(MAKE) test-rules.
(.test-rules.make): Add a level of indirection, by depending on
test-rules.stamp.
2017-05-20 Niels Möller <nisse@lysator.liu.se>
* testsuite/Makefile.in (test-rules): Use $(srddir)/-prefix for
.test-rules.make target, and change dependency from Makefile.in to
Makefile.
2017-05-17 Nikos Mavrogiannopoulos <nmav@redhat.com>
* testsuite/Makefile.in: Ensure .test-rules.make is regenerated
when Makefile.in is modified.
2017-04-09 Niels Möller <nisse@lysator.liu.se>
* testsuite/dlopen-test.c (main): Call dlclose, to fix memory leak
on success.
* testsuite/pss-test.c: Delete magic to let valgrind to check if
pss_encode_mgf1 is side-channel silent with respect to the salt
and digest inputs. It turns out that the most significant bits of
the padded bignum, and hence its size, depends on these inputs.
Which results in a data-dependent branch in the normalization code
of at the end of gmp's mpz_import.
2017-04-04 Niels Möller <nisse@lysator.liu.se>
* pss.c (pss_verify_mgf1): Use const for input mpz_t argument.
(pss_encode_mgf1): Avoid unnecessary memset and xor operations.
Merged RSA-PSS support, contributed by Daiki Ueno.
* pss-mgf1.h, pss.h: New header files.
* pss-mgf1.c (pss_mgf1): New file and function.
* pss.c (pss_encode_mgf1, pss_verify_mgf1): New file and
functions.
* rsa-verify.c (_rsa_verify_recover): New function.
* rsa-pss-sha256-sign-tr.c: (rsa_pss_sha256_sign_digest_tr): New
file and function.
* rsa-pss-sha256-verify.c (rsa_pss_sha256_verify_digest): New
file and function.
* rsa-pss-sha512-sign-tr.c (rsa_pss_sha384_sign_digest_tr)
(rsa_pss_sha512_sign_digest_tr): New file and functions.
* rsa-pss-sha512-verify.c (rsa_pss_sha384_verify_digest)
(rsa_pss_sha512_verify_digest): New file and functions.
* rsa.h: Prototypes for new functions.
* testsuite/rsa-pss-sign-tr-test.c: New test case.
* testsuite/pss-test.c: New test case.
* testsuite/pss-mgf1-test.c: New test case.
* Makefile.in, testsuite/Makefile.in: Added new files.
* nettle.texinfo: Documentation of rsa-pss functions.
2017-03-20 Niels Möller <nisse@lysator.liu.se>
* nettle-internal.h (NETTLE_MAX_HASH_CONTEXT_SIZE): New constant.
* testsuite/meta-hash-test.c (test_main): Add sanity check for
NETTLE_MAX_HASH_CONTEXT_SIZE.
* tools/nettle-hash.c (list_algorithms): Also display the internal
context size.
2017-01-03 Nikos Mavrogiannopoulos <nmav@redhat.com>
* ecdsa-verify.c (ecdsa_verify): Eliminated memory leak on error
path.
2016-10-10 Niels Möller <nisse@lysator.liu.se>
* write-be32.c (_nettle_write_be32): Use const for source argument.
* write-le32.c (_nettle_write_le32): Likewise.
* write-le64.c (_nettle_write_le64): Likewise.
* nettle-write.h: Update prototypes.
2016-10-01 Niels Möller <nisse@lysator.liu.se>
* Released nettle-3.3.
2016-09-13 Niels Möller <nisse@lysator.liu.se>
* nettle-meta-hashes.c (nettle_hashes): Added SHA3 hashes.
Reported missing by Thomas Walter.
* testsuite/meta-hash-test.c: Update test accordingly.
2016-09-07 Niels Möller <nisse@lysator.liu.se>
* nettle.texinfo (Elliptic curves): Split into sub-nodes.
(Miscellaneous functions): Document memeql_sec.
* NEWS: Mention memeql_sec.
2016-09-06 Niels Möller <nisse@lysator.liu.se>
* NEWS: Update for 3.3.
* configure.ac: Bump package version to 3.3.
(LIBNETTLE_MINOR): Bump library version to 6.3.
(LIBHOGWEED_MINOR): Bump library version to 4.3.
2016-09-05 Niels Möller <nisse@lysator.liu.se>
* curve25519.h (NETTLE_CURVE25519_RFC7748): New preprocessor
constant.
* nettle.texinfo: Document it.
2016-09-03 Niels Möller <nisse@lysator.liu.se>
* config.make.in (.SUFFIXES): Delete no longer used .p$(OBJEXT).
* sexp.h (TOKEN_CHAR): Delete macro and declaration of
sexp_token_chars. They belong in tools/misc.h, not here.
* examples/ecc-benchmark.c (die): Deleted unused function.
* testsuite/testutils.h (US): New macro, for unsigned string
literals.
(LDATA): Use the US macro, to eliminate pointer signedness
warnings.
* testsuite/eddsa-verify-test.c (test_eddsa): Use LDATA.
* testsuite/pbkdf2-test.c (test_main): Likewise.
* testsuite/pkcs1-test.c (test_main): Likewise.
* testsuite/md5-compat-test.c (test_main): Use US macro.
* testsuite/sexp-test.c (test_main): Use const char * for assoc
keys. Overlooked in 2016-08-16 change.
* testsuite/yarrow-test.c (test_main): Fix pointer
signednesss warnings.
* testsuite/sexp-format-test.c (test_main): Likewise.
* testsuite/rsa-encrypt-test.c (test_main): Likewise.
* tools/nettle-lfib-stream.c (main): Likewise.
* tools/output.c (sexp_put_string): Likewise.
* testsuite/testutils.c (test_armor): Change ascii argument to
const char *.