Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate names of layers from export cant be viewed simultaneously in viewer #126

Open
Jdgilby opened this issue May 29, 2024 · 3 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@Jdgilby
Copy link

Jdgilby commented May 29, 2024

I've gone through after editing the business logic Riverscapes/RiverscapesXML#715 and found that all layers are loaded into the viewer. However only one realization can be viewed at once.
image
image
You can see in the first image the DCE group is brought in but the layers wont populate. I can remove the ones from the first DCE out of the layer tree and then the other DCE is allowed to populate, but both wont be populated in the layer tree.

This happens to every layer that has a repeat name from DCE to DCE, or even in one DCE if different layers have the same names (pour points, catchments, structural elements).

@KellyMWhitehead please advise if this is just something I wrote wrong in the business logic.

@Jdgilby Jdgilby added the 🐛 bug Something isn't working label May 29, 2024
@KellyMWhitehead
Copy link
Contributor

This is a bug in QViewer - a very old version of code we use to determine if a layer is already in the map. We have a much better system in place for QRiS.

I think the business logic is fine, and seems to work if you change the layer name in the layer tree.

@Jdgilby
Copy link
Author

Jdgilby commented May 30, 2024

@KellyMWhitehead Is it a possibility to fix that in the Viewer? I can see changing the layer name in the tree not being an intuitive fix for the average user viewing data through the viewer.

@KellyMWhitehead
Copy link
Contributor

@Jdgilby yes, I meant to say I will make the fix in the viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants