You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code base is suffering from quite a bit of "tech debt". Here are some ideas for refactoring:
Across the code base nodes and edges sometimes use objects (kgxnode and kgxedge) and sometimes are represented in python dictionaries. Using dictionaries simplified reading and writing json files among other things, but it's really not ideal. We should replace all or most usage of dictionaries with real objects.
Most of the node types, attribute names, and other strings that should be constants defined in one place are set up correctly now, but not all of them. Specifically, as mentioned above, nodes are sometimes represented as dictionaries and the properties "id" "name" and "category" are hard coded in many places. Using objects would solve this but something like "category" should not be in multiple places in the code base, it should be a constant.
Some files are named poorly and should be moved around so that new developers can more quickly understand the overall structure. Load_manager and build_manager should be renamed and moved, as they are the entry points for usage, and those names are bad. Node and edge normalization should be moved out of utils. The "kgx" terminology is over used. "node_types" holds more than just node types now.
The text was updated successfully, but these errors were encountered:
The code base is suffering from quite a bit of "tech debt". Here are some ideas for refactoring:
Across the code base nodes and edges sometimes use objects (kgxnode and kgxedge) and sometimes are represented in python dictionaries. Using dictionaries simplified reading and writing json files among other things, but it's really not ideal. We should replace all or most usage of dictionaries with real objects.
Most of the node types, attribute names, and other strings that should be constants defined in one place are set up correctly now, but not all of them. Specifically, as mentioned above, nodes are sometimes represented as dictionaries and the properties "id" "name" and "category" are hard coded in many places. Using objects would solve this but something like "category" should not be in multiple places in the code base, it should be a constant.
Some files are named poorly and should be moved around so that new developers can more quickly understand the overall structure. Load_manager and build_manager should be renamed and moved, as they are the entry points for usage, and those names are bad. Node and edge normalization should be moved out of utils. The "kgx" terminology is over used. "node_types" holds more than just node types now.
The text was updated successfully, but these errors were encountered: