Slight tweaks to tests

sea-bass · sea-bass · commit 1119e34b6a13 · 2023-11-01T14:46:07.000-04:00
diff --git a/rosbridge_library/src/rosbridge_library/capabilities/advertise_action.py b/rosbridge_library/src/rosbridge_library/capabilities/advertise_action.py
@@ -82,6 +82,7 @@ async def execute_callback(self, goal):
             "action": self.action_name,
             "action_type": self.action_type,
             "args": message_conversion.extract_values(goal.request),
+            "feedback": True,
         }
         self.protocol.send(goal_message)
 
diff --git a/rosbridge_library/test/capabilities/test_action_capabilities.py b/rosbridge_library/test/capabilities/test_action_capabilities.py
@@ -115,8 +115,8 @@ def test_execute_advertised_action(self):
         goal_msg = loads(
             dumps(
                 {
-                    "op": "call_service",
-                    "id": "foo",
+                    "op": "send_action_goal",
+                    "id": "foo2",
                     "action": action_path,
                     "action_type": "example_interfaces/Fibonacci",
                     "args": {"order": 5},
@@ -219,7 +219,7 @@ def test_cancel_advertised_action(self):
             dumps(
                 {
                     "op": "send_action_goal",
-                    "id": "foo",
+                    "id": "foo3",
                     "action": action_path,
                     "action_type": "example_interfaces/Fibonacci",
                     "args": {"order": 5},
@@ -246,7 +246,7 @@ def test_cancel_advertised_action(self):
                 {
                     "op": "cancel_action_goal",
                     "action": action_path,
-                    "id": "foo",
+                    "id": "foo3",
                 }
             )
         )
@@ -287,7 +287,7 @@ def test_unadvertise_action(self):
             dumps(
                 {
                     "op": "send_action_goal",
-                    "id": "foo",
+                    "id": "foo4",
                     "action": action_path,
                     "action_type": "example_interfaces/Fibonacci",
                     "args": {"order": 5},

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ async def execute_callback(self, goal):`
`82`	`82`	`"action": self.action_name,`
`83`	`83`	`"action_type": self.action_type,`
`84`	`84`	`"args": message_conversion.extract_values(goal.request),`
	`85`	`+ "feedback": True,`
`85`	`86`	`}`
`86`	`87`	`self.protocol.send(goal_message)`
`87`	`88`
Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,8 @@ def test_execute_advertised_action(self):`
`115`	`115`	`goal_msg = loads(`
`116`	`116`	`dumps(`
`117`	`117`	`{`
`118`		`- "op": "call_service",`
`119`		`- "id": "foo",`
	`118`	`+ "op": "send_action_goal",`
	`119`	`+ "id": "foo2",`
`120`	`120`	`"action": action_path,`
`121`	`121`	`"action_type": "example_interfaces/Fibonacci",`
`122`	`122`	`"args": {"order": 5},`
`@@ -219,7 +219,7 @@ def test_cancel_advertised_action(self):`
`219`	`219`	`dumps(`
`220`	`220`	`{`
`221`	`221`	`"op": "send_action_goal",`
`222`		`- "id": "foo",`
	`222`	`+ "id": "foo3",`
`223`	`223`	`"action": action_path,`
`224`	`224`	`"action_type": "example_interfaces/Fibonacci",`
`225`	`225`	`"args": {"order": 5},`
`@@ -246,7 +246,7 @@ def test_cancel_advertised_action(self):`
`246`	`246`	`{`
`247`	`247`	`"op": "cancel_action_goal",`
`248`	`248`	`"action": action_path,`
`249`		`- "id": "foo",`
	`249`	`+ "id": "foo3",`
`250`	`250`	`}`
`251`	`251`	`)`
`252`	`252`	`)`
`@@ -287,7 +287,7 @@ def test_unadvertise_action(self):`
`287`	`287`	`dumps(`
`288`	`288`	`{`
`289`	`289`	`"op": "send_action_goal",`
`290`		`- "id": "foo",`
	`290`	`+ "id": "foo4",`
`291`	`291`	`"action": action_path,`
`292`	`292`	`"action_type": "example_interfaces/Fibonacci",`
`293`	`293`	`"args": {"order": 5},`