Skip to content

Commit 5d93ca0

Browse files
committed
Disable another action test since there is a rclpy bug
1 parent 03c350f commit 5d93ca0

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

rosbridge_library/src/rosbridge_library/capabilities/advertise_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def next_id(self):
3131

3232
async def handle_request(self, req, res):
3333
# generate a unique ID
34-
request_id = "service_request:" + self.service_name + ":" + str(self.next_id())
34+
request_id = f"service_request:{self.service_name }:{self.next_id()}"
3535

3636
future = rclpy.task.Future()
3737
self.request_futures[request_id] = future

rosbridge_library/test/capabilities/test_action_capabilities.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ def test_advertise_action(self):
9595
)
9696
self.advertise.advertise_action(advertise_msg)
9797

98+
@unittest.skip(
99+
reason="Currently fails in Iron/Rolling due to https://github.com/ros2/rclpy/issues/1195, need to fix this"
100+
)
98101
def test_execute_advertised_action(self):
99102
# Advertise the action
100103
action_path = "/fibonacci_action_2"

0 commit comments

Comments
 (0)