New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off site specific code from fsainsert.bg into individual scripts #3

Open

Rohaq opened this issue Jul 19, 2017 · 0 comments

Assignees

Owner

Rohaq commented Jul 19, 2017

No-one likes a monolith. If we're want to support more sites, it's worth fixing this early.

Code specific to scraping and inserting into each site should be split off into their own js files, and explicitly specified in the manifest.json for each site individually.
fsainsert.js should be updated to accept input from any of these scripts, and used to handle messaging to fsabg.js, returning required FSA data to requestor. It might also be worth renaming to something sensible.

Rohaq self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment