Skip to content

Commit 3594fb7

Browse files
authored
Merge pull request #230 from RonasIT/140-use-NovaResource-class-in-NovaTestGenerator-instead-of-Model
refactor: rename nova test dump
2 parents 9593a33 + f1bfd5a commit 3594fb7

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

src/Generators/NovaTestGenerator.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -209,13 +209,6 @@ protected function getFilters(): array
209209
return $filters;
210210
}
211211

212-
protected function getDumpName(): string
213-
{
214-
$entityName = Str::snake($this->getTestingEntityName());
215-
216-
return "nova_{$entityName}_dump.sql";
217-
}
218-
219212
protected function getTestingEntityName(): string
220213
{
221214
return Str::afterLast($this->novaResourceClassName, '\\');

tests/CommandTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public function testCallCommand()
9191
$this->assertGeneratedFileEquals('validation.php', 'lang/en/validation.php');
9292
$this->assertGeneratedFileEquals('nova_resource.php', 'app/Nova/PostResource.php');
9393
$this->assertGeneratedFileEquals('nova_test.php', 'tests/NovaPostResourceTest.php');
94-
$this->assertGeneratedFileEquals('nova_dump.php', 'tests/fixtures/NovaPostResourceTest/nova_post_resource_dump.sql');
94+
$this->assertGeneratedFileEquals('nova_dump.php', 'tests/fixtures/NovaPostResourceTest/dump.sql');
9595
$this->assertGeneratedFileEquals('create_request.json', 'tests/fixtures/NovaPostResourceTest/create_post_resource_request.json');
9696
$this->assertGeneratedFileEquals('create_response.json', 'tests/fixtures/NovaPostResourceTest/create_post_resource_response.json');
9797
$this->assertGeneratedFileEquals('update_request.json', 'tests/fixtures/NovaPostResourceTest/update_post_resource_request.json');
@@ -137,7 +137,7 @@ public function testCallCommandSubFoldersModel()
137137
$this->assertGeneratedFileEquals('create_response.json', 'tests/fixtures/PostTest/create_post_response.json');
138138
$this->assertGeneratedFileEquals('update_request.json', 'tests/fixtures/PostTest/update_post_request.json');
139139
$this->assertGeneratedFileEquals('validation.php', 'lang/en/validation.php');
140-
$this->assertGeneratedFileEquals('nova_dump.php', 'tests/fixtures/NovaPostResourceTest/nova_post_resource_dump.sql');
140+
$this->assertGeneratedFileEquals('nova_dump.php', 'tests/fixtures/NovaPostResourceTest/dump.sql');
141141
$this->assertGeneratedFileEquals('create_request.json', 'tests/fixtures/NovaPostResourceTest/create_post_resource_request.json');
142142
$this->assertGeneratedFileEquals('create_response.json', 'tests/fixtures/NovaPostResourceTest/create_post_resource_response.json');
143143
$this->assertGeneratedFileEquals('update_request.json', 'tests/fixtures/NovaPostResourceTest/update_post_resource_request.json');
@@ -174,7 +174,7 @@ public function testMakeOnly()
174174
$this->assertFileDoesNotExist('lang/en/validation.php');
175175
$this->assertFileDoesNotExist('app/Nova/PostResource.php');
176176
$this->assertFileDoesNotExist('tests/NovaPostTest.php');
177-
$this->assertFileDoesNotExist('tests/fixtures/NovaPostTest/nova_post_dump.sql');
177+
$this->assertFileDoesNotExist('tests/fixtures/NovaPostTest/dump.sql');
178178
$this->assertFileDoesNotExist('tests/fixtures/NovaPostTest/create_post_request.json');
179179
$this->assertFileDoesNotExist('tests/fixtures/NovaPostTest/create_post_response.json');
180180
$this->assertFileDoesNotExist('tests/fixtures/NovaPostTest/update_post_request.json');

tests/NovaTestGeneratorTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function testNovaTestStubNotExist()
110110
->generate();
111111

112112
$this->assertFileDoesNotExist('tests/NovaWelcomeBonusResourceTest.php');
113-
$this->assertGeneratedFileEquals('dump.sql', 'tests/fixtures/NovaWelcomeBonusResourceTest/nova_welcome_bonus_resource_dump.sql');
113+
$this->assertGeneratedFileEquals('dump.sql', 'tests/fixtures/NovaWelcomeBonusResourceTest/dump.sql');
114114
$this->assertGeneratedFileEquals('create_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_request.json');
115115
$this->assertGeneratedFileEquals('create_welcome_bonus_response.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_response.json');
116116
$this->assertGeneratedFileEquals('update_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/update_welcome_bonus_resource_request.json');
@@ -143,7 +143,7 @@ public function testDumpStubNotExist()
143143
->generate();
144144

145145
$this->assertGeneratedFileEquals('created_resource_test.php', 'tests/NovaWelcomeBonusResourceTest.php');
146-
$this->assertFileDoesNotExist('tests/fixtures/NovaWelcomeBonusResourceTest/nova_welcome_bonus_resource_dump.sql');
146+
$this->assertFileDoesNotExist('tests/fixtures/NovaWelcomeBonusResourceTest/dump.sql');
147147
$this->assertGeneratedFileEquals('create_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_request.json');
148148
$this->assertGeneratedFileEquals('create_welcome_bonus_response.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_response.json');
149149
$this->assertGeneratedFileEquals('update_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/update_welcome_bonus_resource_request.json');
@@ -180,7 +180,7 @@ public function testSuccess()
180180
->generate();
181181

182182
$this->assertGeneratedFileEquals('created_resource_test.php', 'tests/NovaWelcomeBonusResourceTest.php');
183-
$this->assertGeneratedFileEquals('dump.sql', 'tests/fixtures/NovaWelcomeBonusResourceTest/nova_welcome_bonus_resource_dump.sql');
183+
$this->assertGeneratedFileEquals('dump.sql', 'tests/fixtures/NovaWelcomeBonusResourceTest/dump.sql');
184184
$this->assertGeneratedFileEquals('create_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_request.json');
185185
$this->assertGeneratedFileEquals('create_welcome_bonus_response.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/create_welcome_bonus_resource_response.json');
186186
$this->assertGeneratedFileEquals('update_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusResourceTest/update_welcome_bonus_resource_request.json');

0 commit comments

Comments
 (0)