header_major_fixed.m4 is a bad idea #616
Comments
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
May 23, 2024
rsync has a fork of the pre-2016 AC_HEADER_MAJOR with a different fix from the one autoconf itself implemented. It raises a FP for: * QA Notice: Found the following implicit function declarations in configure logs: * /var/tmp/portage/net-misc/rsync-3.3.0/work/rsync-3.3.0/config.log:1159 - makedev which is anyways not supposed to be found. We could ignore it, but better to get rid of the macro itself, considering we anyways often regenerate autoreconf. Resulting configure run has no actual differences, just the FP or lack of FP (and running one fewer compiler probe in src_configure). No revbump. Bug: RsyncProject/rsync#616 Closes: https://bugs.gentoo.org/916481 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org>
immolo
pushed a commit
to immolo/gentoo
that referenced
this issue
May 24, 2024
rsync has a fork of the pre-2016 AC_HEADER_MAJOR with a different fix from the one autoconf itself implemented. It raises a FP for: * QA Notice: Found the following implicit function declarations in configure logs: * /var/tmp/portage/net-misc/rsync-3.3.0/work/rsync-3.3.0/config.log:1159 - makedev which is anyways not supposed to be found. We could ignore it, but better to get rid of the macro itself, considering we anyways often regenerate autoreconf. Resulting configure run has no actual differences, just the FP or lack of FP (and running one fewer compiler probe in src_configure). No revbump. Bug: RsyncProject/rsync#616 Closes: https://bugs.gentoo.org/916481 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Added in 2020: 5e4a144
It is trying to fix AC_HEADER_MAJOR being broken in autoconf itself, but the correct fix was implemented in 2016 by autoconf: autotools-mirror/autoconf@e17a30e
It wasn't released until 2.69b, which happened a couple months after the checkin of the macro to rsync. Another 4 years later, rsync distributes with a configure.sh built from autoconf 2.71, that includes the temporary override instead of the good fixed macros from autoconf.
Originally reported as https://bugs.gentoo.org/916481
The text was updated successfully, but these errors were encountered: