From c102c6f55aeb0be8a0fc0da75881395f25281647 Mon Sep 17 00:00:00 2001
From: RussTreadon-NOAA <Russ.Treadon@noaa.gov>
Date: Tue, 13 Feb 2024 20:28:23 +0000
Subject: [PATCH] correct shellcheck errors (#2294)

---
 parm/config/gfs/config.esfc     |  2 +-
 parm/config/gfs/config.nsst     |  2 +-
 parm/config/gfs/config.sfcanl   |  2 +-
 parm/config/gfs/config.stage_ic |  2 +-
 scripts/exglobal_stage_ic.sh    | 20 ++++++++++----------
 5 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/parm/config/gfs/config.esfc b/parm/config/gfs/config.esfc
index 7a5bce4681..7c32313758 100644
--- a/parm/config/gfs/config.esfc
+++ b/parm/config/gfs/config.esfc
@@ -17,7 +17,7 @@ if [ $DOIAU_ENKF = "YES" ]; then
 fi
 
 # Turn off NST in JEDIATMENS
-if [ $DO_JEDIATMENS = "YES" ]; then
+if [[ "${DO_JEDIATMENS}" == "YES" ]]; then
    export DONST="NO"
 fi
 
diff --git a/parm/config/gfs/config.nsst b/parm/config/gfs/config.nsst
index a85e87b47f..7bda81f058 100644
--- a/parm/config/gfs/config.nsst
+++ b/parm/config/gfs/config.nsst
@@ -11,7 +11,7 @@ echo "BEGIN: config.nsst"
 export NST_MODEL=2
 
 # Set NST_MODEL for JEDIATMVAR or JEDIATMENS
-if [[ $DO_JEDIATMVAR = "YES" || $DO_JEDIATMENS = "YES" ]]; then
+if [[ "${DO_JEDIATMVAR}" == "YES" || "${DO_JEDIATMENS}" == "YES" ]]; then
    export NST_MODEL=1
 fi
 
diff --git a/parm/config/gfs/config.sfcanl b/parm/config/gfs/config.sfcanl
index aa08f5a692..e2fde8992a 100644
--- a/parm/config/gfs/config.sfcanl
+++ b/parm/config/gfs/config.sfcanl
@@ -9,7 +9,7 @@ echo "BEGIN: config.sfcanl"
 . $EXPDIR/config.resources sfcanl
 
 # Turn off NST in JEDIATMVAR
-if [ $DO_JEDIATMVAR = "YES" ]; then
+if [[ "${DO_JEDIATMVAR}" == "YES" ]]; then
    export DONST="NO"
 fi
 
diff --git a/parm/config/gfs/config.stage_ic b/parm/config/gfs/config.stage_ic
index 2583f831ac..a99fa88bf6 100644
--- a/parm/config/gfs/config.stage_ic
+++ b/parm/config/gfs/config.stage_ic
@@ -42,7 +42,7 @@ esac
 fi # End block for coupled ICs
 
 # Stage ICs for cycled runs
-if [[ "$MODE" = "cycled" ]]; then
+if [[ "${MODE}" == "cycled" ]]; then
   export CPL_ATMIC="C48C48"
   export CPL_ATMDAIC="C48C48"
 fi
diff --git a/scripts/exglobal_stage_ic.sh b/scripts/exglobal_stage_ic.sh
index e08e4c892c..17c2e0d8dc 100755
--- a/scripts/exglobal_stage_ic.sh
+++ b/scripts/exglobal_stage_ic.sh
@@ -158,9 +158,9 @@ done # for MEMDIR in "${MEMDIR_ARRAY[@]}"; do
 else
   # Stage deterministic ICs from previous cycle
   RUN=${rCDUMP} YMD=${gPDY} HH=${gcyc} generate_com COM_TOP:COM_TOP_TMPL
-  COM_TOP_BASE=$(dirname $COM_TOP)
+  COM_TOP_BASE=$(dirname "${COM_TOP}")
   [[ ! -d "${COM_TOP_BASE}" ]] && mkdir -p "${COM_TOP_BASE}"
-  [[ -d "${COM_TOP_BASE}/${gcyc}" ]] && rm -rf "${COM_TOP_BASE}/${gcyc}"
+  [[ -d "${COM_TOP_BASE}/${gcyc}" ]] && rm -f "${COM_TOP_BASE:-}/${gcyc:-}"
   src="${BASE_CPLIC}/${CPL_ATMIC:-}/${RUN}.${gPDY}/${gcyc}"
   tgt="${COM_TOP_BASE}/"
   ${NLN} "${src}" "${tgt}"
@@ -171,9 +171,9 @@ else
   # Stage ensemble ICs from previous cycle
   if [[ "${DOHYBVAR}" == "YES" ]]; then
     RUN=enkf${rCDUMP} YMD=${gPDY} HH=${gcyc} generate_com COM_TOP:COM_TOP_TMPL
-    COM_TOP_BASE=$(dirname $COM_TOP)
+    COM_TOP_BASE=$(dirname "${COM_TOP}")
     [[ ! -d "${COM_TOP_BASE}" ]] && mkdir -p "${COM_TOP_BASE}"
-    [[ -d "${COM_TOP_BASE}/${gcyc}" ]] && rm -rf "${COM_TOP_BASE}/${gcyc}"
+    [[ -d "${COM_TOP_BASE}/${gcyc}" ]] && rm -rf "${COM_TOP_BASE:-}/${gcyc:-}"
     src="${BASE_CPLIC}/${CPL_ATMIC:-}/enkf${RUN}.${gPDY}/${gcyc}"
     tgt="${COM_TOP_BASE}/"
     ${NLN} "${src}" "${tgt}"
@@ -192,17 +192,17 @@ else
   else
     flist="abias abias_air abias_pc radstat"
   fi
-  for ftype in $flist; do
-    file=${rCDUMP}.t${cyc}z.$ftype
-    ${NCP} "${src}/$file" "${tgt}"
+  for ftype in ${flist}; do
+    file=${rCDUMP}.t${cyc}z.${ftype}
+    ${NCP} "${src}"/"${file}" "${tgt}"
     rc=$?
     ((rc != 0)) && error_message "${src}" "${tgt}" "${rc}"
     err=$((err + rc))
   done
   if [[ "${DO_JEDIATMVAR}" == "YES" || "${DO_JEDIATMENS}" == "YES" ]]; then
-    cd ${tgt}
-    tar -xvf ${rCDUMP}.t${cyc}z.radbcor
-    cd ${DATA}
+    cd "${tgt}" || exit
+    tar -xvf "${rCDUMP}".t"${cyc}"z.radbcor
+    cd "${DATA}" || exit
   fi
 
 fi