Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline PR integration tests for FlowEHR & FlowEHR Data Pipeline repos #334

Open
jjgriff93 opened this issue Oct 5, 2023 · 0 comments
Open
Labels
Feature Feature level item needs: triage Item is pending initial response by a maintainer.

Comments

@jjgriff93
Copy link
Member

jjgriff93 commented Oct 5, 2023

Is your feature request related to a problem? Please describe.
Currently on PRs, we have a simple check that the configured pipelines run successfully. This doesn't give us any insight into whether the pipelines performed the expected transformations/produced the expected results. We're also unable to specify only specific pipelines for PR tests vs running all of the pipelines that are configured to be deployed once the PR is merged. Finally, there is no easy way to test pipelines in a pipeline repo (i.e. a data pot/seedling) on PR. These first have to be merged and then referenced by a FlowEHR deployment by SHA.

Describe the solution you'd like
Within a FlowEHR pipeline, it would be useful to be able to define an optional activity (or multiple) that are ran when a flag is enabled, which runs after the main pipeline(s) has ran, which can perform assertions and other tests to make sure the results of the pipeline(s) are as expected.

FlowEHR should then set a flag and run this activity on deployments and fail the deployment if the activity fails. It should, however, NOT run this activity on standard invocations of the pipeline(s) (i.e. when triggered by TumblingWindowTrigger Data Factory triggers or whatever triggers are configured within the pipelines).

Also for pipeline repositories themselves (in the data pot templates), it would be useful to have a mechanism for configuring a FlowEHR instance to target, then be able to test the pipeline(s) on PR by running them on the instance, and failing if the pipelines or the final testing activity fails, so that we can iron out any e2e pipeline bugs before merging and then setting up to deploy to FlowEHR.

fyi @tanya-borisova if you have anything to add

@jjgriff93 jjgriff93 added the Feature Feature level item label Oct 5, 2023
@jjgriff93 jjgriff93 added this to FlowEHR Oct 5, 2023
@github-actions github-actions bot added the needs: triage Item is pending initial response by a maintainer. label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature level item needs: triage Item is pending initial response by a maintainer.
Projects
Status: No status
Development

No branches or pull requests

1 participant