Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since core.uploader is now only used by pixl_export should we just move it over from core? #384

Open
jeremyestein opened this issue Apr 30, 2024 · 1 comment
Open

Since core.uploader is now only used by pixl_export should we just move it over from core? #384

jeremyestein opened this issue Apr 30, 2024 · 1 comment

Comments

@jeremyestein
Copy link
Contributor

jeremyestein commented Apr 30, 2024 •
edited
Loading

Since core.uploader is now only used by pixl_export should we just move it over from core?

Originally posted by @milanmlft in #370 (comment)

See also the reply to that comment
@jeremyestein jeremyestein mentioned this issue Apr 30, 2024
Merged
8 tasks
@milanmlft
Copy link
Member

Hmm upon closer inspection, core.uploader is also used in core.exports, which in turn is used in cli. So moving these bits over would require a bigger refactoring. Not sure if worth it at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremyestein @milanmlft