From cf80ddd872d8fe4fb588d02d1771910cf457c974 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20J=C3=BCliger?= Date: Wed, 17 Sep 2025 09:24:19 +0200 Subject: [PATCH 1/2] "must" -> "should" for recommendations --- src/checks/y_check_branch_coverage.clas.abap | 2 +- src/checks/y_check_comment_usage.clas.abap | 2 +- src/checks/y_check_cyclomatic_complexity.clas.abap | 2 +- src/checks/y_check_max_nesting_depth.clas.abap | 2 +- src/checks/y_check_num_exec_statements.clas.abap | 2 +- src/checks/y_check_num_output_parameter.clas.abap | 2 +- src/checks/y_check_number_attributes.clas.abap | 2 +- src/checks/y_check_number_events.clas.abap | 2 +- src/checks/y_check_number_interfaces.clas.abap | 2 +- src/checks/y_check_number_methods.clas.abap | 2 +- src/checks/y_check_procedure_coverage.clas.abap | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/checks/y_check_branch_coverage.clas.abap b/src/checks/y_check_branch_coverage.clas.abap index 48409e07..7f115620 100644 --- a/src/checks/y_check_branch_coverage.clas.abap +++ b/src/checks/y_check_branch_coverage.clas.abap @@ -25,7 +25,7 @@ CLASS y_check_branch_coverage IMPLEMENTATION. settings-ignore_pseudo_comments = abap_true. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. - set_check_message( 'Branch Coverage must be higher than &2%! (&1%<=&2%)' ). + set_check_message( 'Branch Coverage should be higher than &2%! (&1%<=&2%)' ). ENDMETHOD. diff --git a/src/checks/y_check_comment_usage.clas.abap b/src/checks/y_check_comment_usage.clas.abap index 32cae84c..c1388f98 100644 --- a/src/checks/y_check_comment_usage.clas.abap +++ b/src/checks/y_check_comment_usage.clas.abap @@ -45,7 +45,7 @@ CLASS y_check_comment_usage IMPLEMENTATION. ( scan_struc_stmnt_type-function ) ( scan_struc_stmnt_type-module ) ). - set_check_message( 'Percentage of comments must be lower than &3% of the productive code! (&2%>=&3%) (&1 lines found)' ). + set_check_message( 'Percentage of comments should be lower than &3% of the productive code! (&2%>=&3%) (&1 lines found)' ). ENDMETHOD. diff --git a/src/checks/y_check_cyclomatic_complexity.clas.abap b/src/checks/y_check_cyclomatic_complexity.clas.abap index 5686dc8b..f6a8d046 100644 --- a/src/checks/y_check_cyclomatic_complexity.clas.abap +++ b/src/checks/y_check_cyclomatic_complexity.clas.abap @@ -58,7 +58,7 @@ CLASS Y_CHECK_CYCLOMATIC_COMPLEXITY IMPLEMENTATION. settings-threshold = 10. settings-documentation = |{ c_docs_path-checks }cyclomatic-complexity.md|. - set_check_message( 'Cyclomatic complexity must be lower than &2! (&1>=&2)' ). + set_check_message( 'Cyclomatic complexity should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_max_nesting_depth.clas.abap b/src/checks/y_check_max_nesting_depth.clas.abap index 49ecfd5c..6da6eb99 100644 --- a/src/checks/y_check_max_nesting_depth.clas.abap +++ b/src/checks/y_check_max_nesting_depth.clas.abap @@ -61,7 +61,7 @@ CLASS y_check_max_nesting_depth IMPLEMENTATION. settings-pseudo_comment = '"#EC CI_NESTING' ##NO_TEXT. settings-documentation = |{ c_docs_path-checks }maximum-nesting-depth.md|. - set_check_message( 'Nesting depth must be lower than &2! (&1>=&2)' ). + set_check_message( 'Nesting depth should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_num_exec_statements.clas.abap b/src/checks/y_check_num_exec_statements.clas.abap index 2ca6c407..eb0101c3 100644 --- a/src/checks/y_check_num_exec_statements.clas.abap +++ b/src/checks/y_check_num_exec_statements.clas.abap @@ -36,7 +36,7 @@ CLASS Y_CHECK_NUM_EXEC_STATEMENTS IMPLEMENTATION. add_obj_type( c_type_program ). - set_check_message( 'Number of executable statements must be lower than &2! (&1>=&2)' ). + set_check_message( 'Number of executable statements should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_num_output_parameter.clas.abap b/src/checks/y_check_num_output_parameter.clas.abap index f41787fc..158aca96 100644 --- a/src/checks/y_check_num_output_parameter.clas.abap +++ b/src/checks/y_check_num_output_parameter.clas.abap @@ -28,7 +28,7 @@ CLASS y_check_num_output_parameter IMPLEMENTATION. relevant_structure_types = VALUE #( ). - set_check_message( 'Number of output parameters must be less than &2! (but is &1)' ). + set_check_message( 'Number of output parameters should be less than &2! (but is &1)' ). ENDMETHOD. diff --git a/src/checks/y_check_number_attributes.clas.abap b/src/checks/y_check_number_attributes.clas.abap index e0846a64..c38c9a35 100644 --- a/src/checks/y_check_number_attributes.clas.abap +++ b/src/checks/y_check_number_attributes.clas.abap @@ -38,7 +38,7 @@ CLASS y_check_number_attributes IMPLEMENTATION. relevant_structure_types = VALUE #( ). - set_check_message( 'Number of attributes must be lower than &2! (&1>=&2)' ). + set_check_message( 'Number of attributes should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_number_events.clas.abap b/src/checks/y_check_number_events.clas.abap index cee6b03a..1b402bad 100644 --- a/src/checks/y_check_number_events.clas.abap +++ b/src/checks/y_check_number_events.clas.abap @@ -29,7 +29,7 @@ CLASS Y_CHECK_NUMBER_EVENTS IMPLEMENTATION. relevant_structure_types = VALUE #( ). - set_check_message( 'Number of events must be lower than &2! (&1>=&2)' ). + set_check_message( 'Number of events should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_number_interfaces.clas.abap b/src/checks/y_check_number_interfaces.clas.abap index 30e3f491..0aabf422 100644 --- a/src/checks/y_check_number_interfaces.clas.abap +++ b/src/checks/y_check_number_interfaces.clas.abap @@ -30,7 +30,7 @@ CLASS y_check_number_interfaces IMPLEMENTATION. relevant_structure_types = VALUE #( ). - set_check_message( 'Number of interfaces must be lower than &2! (&1>=&2)' ). + set_check_message( 'Number of interfaces should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_number_methods.clas.abap b/src/checks/y_check_number_methods.clas.abap index 680783eb..db04c4b5 100644 --- a/src/checks/y_check_number_methods.clas.abap +++ b/src/checks/y_check_number_methods.clas.abap @@ -31,7 +31,7 @@ CLASS Y_CHECK_NUMBER_METHODS IMPLEMENTATION. relevant_structure_types = VALUE #( ). - set_check_message( 'Number of methods must be lower than &2! (&1>=&2)' ). + set_check_message( 'Number of methods should be lower than &2! (&1>=&2)' ). ENDMETHOD. diff --git a/src/checks/y_check_procedure_coverage.clas.abap b/src/checks/y_check_procedure_coverage.clas.abap index 04ac0d0f..446a56e2 100644 --- a/src/checks/y_check_procedure_coverage.clas.abap +++ b/src/checks/y_check_procedure_coverage.clas.abap @@ -25,7 +25,7 @@ CLASS y_check_procedure_coverage IMPLEMENTATION. settings-ignore_pseudo_comments = abap_true. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. - set_check_message( 'Procedure Coverage must be higher than &2%! (&1%<=&2%)' ). + set_check_message( 'Procedure coverage should be higher than &2%! (&1%<=&2%)' ). ENDMETHOD. From 38736f5c6f6fc5c2976255067b7a76ac04717d2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20J=C3=BCliger?= Date: Wed, 17 Sep 2025 09:27:53 +0200 Subject: [PATCH 2/2] consistent capitalization --- src/checks/y_check_branch_coverage.clas.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/checks/y_check_branch_coverage.clas.abap b/src/checks/y_check_branch_coverage.clas.abap index 7f115620..b2c3d851 100644 --- a/src/checks/y_check_branch_coverage.clas.abap +++ b/src/checks/y_check_branch_coverage.clas.abap @@ -25,7 +25,7 @@ CLASS y_check_branch_coverage IMPLEMENTATION. settings-ignore_pseudo_comments = abap_true. settings-documentation = |{ c_docs_path-checks }unit-test-coverages.md|. - set_check_message( 'Branch Coverage should be higher than &2%! (&1%<=&2%)' ). + set_check_message( 'Branch coverage should be higher than &2%! (&1%<=&2%)' ). ENDMETHOD.