Fix/sonar code smells webapp (#583)

* fix: typescript:S6848

* fix: sonar code smells in webapp

* chore: changeset

* fix: sonar code smells in webapp

Author: Klaus-Keller

.changeset/six-dogs-bow.md

@@ -0,0 +1,5 @@
+---
+'@sap/guided-answers-extension-webapp': patch
+---
+
+Fix code smells in webapp

packages/webapp/src/webview/ui/components/FeedbackSection/NotSolvedMessage/NotSolvedMessage.tsx

@@ -35,7 +35,7 @@ export default function NotSolvedMessage(): ReactElement {
                     isCircularNavigation={true}>
                     {options.map((btn) => (
                         <div className="guided-answer__node" key={btn.link}>
-                            <a className="guided-answer__node__edge not-solved-link" href={btn.link} role="button">
+                            <a className="guided-answer__node__edge not-solved-link" href={btn.link}>
                                 {i18next.t(btn.text)}
                             </a>
                         </div>

packages/webapp/src/webview/ui/components/GuidedAnswerNavPath/GuidedAnswerNavPath.tsx

@@ -28,7 +28,6 @@ export function GuidedAnswerNavPath(): ReactElement {
             <nav className="container">
                 <FocusZone
                     direction={FocusZoneDirection.vertical}
-                    role="tree"
                     onFocus={() => {
                         if (firstTimeFocus) {
                             focusOnElement('.timeline-content');
@@ -38,7 +37,7 @@ export function GuidedAnswerNavPath(): ReactElement {
                     isCircularNavigation={true}>
                     {nodes.map((node, i) => {
                         return (
-                            <div key={`timeline-block-${node.TITLE}`} className="timeline-block" role="treeitem">
+                            <div key={`timeline-block-${node.TITLE}`} className="timeline-block">
                                 <button
                                     id="timeline-content"
                                     className={`timeline-content ${i === lastIndex ? lastBlockBorderStyle : ''}`}

packages/webapp/test/FeedbackSection/__snapshots__/NotSolvedMessage.test.tsx.snap

@@ -39,7 +39,6 @@ exports[`<NotSolvedMessage/> Should render a NotSolvedMessage component 1`] = `
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/expertchat/create"
-            role="button"
             tabindex="0"
           >
             Start an Expert Chat
@@ -51,7 +50,6 @@ exports[`<NotSolvedMessage/> Should render a NotSolvedMessage component 1`] = `
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/sae"
-            role="button"
             tabindex="-1"
           >
             Schedule an Expert
@@ -63,7 +61,6 @@ exports[`<NotSolvedMessage/> Should render a NotSolvedMessage component 1`] = `
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/incident/create"
-            role="button"
             tabindex="-1"
           >
             Open an Incident
@@ -75,7 +72,6 @@ exports[`<NotSolvedMessage/> Should render a NotSolvedMessage component 1`] = `
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://answers.sap.com/index.html"
-            role="button"
             tabindex="-1"
           >
             Ask the SAP Community

packages/webapp/test/GuidedAnswerNode/__snapshots__/Middle.test.tsx.snap

@@ -173,7 +173,6 @@ exports[`<Middle /> Should render a Middle component with NotSolvedMessage 1`] =
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/expertchat/create"
-            role="button"
             tabindex="0"
           >
             Start an Expert Chat
@@ -185,7 +184,6 @@ exports[`<Middle /> Should render a Middle component with NotSolvedMessage 1`] =
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/sae"
-            role="button"
             tabindex="-1"
           >
             Schedule an Expert
@@ -197,7 +195,6 @@ exports[`<Middle /> Should render a Middle component with NotSolvedMessage 1`] =
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://launchpad.support.sap.com/#/incident/create"
-            role="button"
             tabindex="-1"
           >
             Open an Incident
@@ -209,7 +206,6 @@ exports[`<Middle /> Should render a Middle component with NotSolvedMessage 1`] =
           <a
             class="guided-answer__node__edge not-solved-link"
             href="https://answers.sap.com/index.html"
-            role="button"
             tabindex="-1"
           >
             Ask the SAP Community

packages/webapp/test/__snapshots__/GuidedAnswerNavPath.test.tsx.snap

@@ -8,11 +8,9 @@ exports[`<GuidedAnswerNavPath /> Should render a GuidedAnswerNavPath component 1
     <div
       class="ms-FocusZone css-101"
       data-focuszone-id="FocusZone0"
-      role="tree"
     >
       <div
         class="timeline-block"
-        role="treeitem"
       >
         <button
           class="timeline-content timeline-content-bottom-border"