Skip to content

Commit 46fcdd1

Browse files
thtricx-michael-kubiaczyksumeetpatilhubadr
authored
[CxONE] Improve report: add Low findings; Proposed Not Exploitable state (#5223)
* Initial in progress * compiling but not yet functional * Missed file * updated checkmarxone step * Working up to fetching a project then breaks * Missed file * Breaks when retrieving projects+proxy set * Create project & run scan working, now polling * Fixed polling * added back the zipfile remove command * Fixed polling again * Generates and downloads PDF report * Updated and working, prep for refactor * Added compliance steps * Cleanup, reporting, added groovy connector * fixed groovy file * checkmarxone to checkmarxOne * checkmarxone to checkmarxOne * split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix * Fixed filenames & yaml * missed the metadata_generated.go * added json to sarif conversion * fix:type in new checkmarxone package * fix:type in new checkmarxone package * removed test logs, added temp error log for creds * extra debugging to fix crash * improved auth logging, fixed query parse issue * fixed bug with group fetch when using oauth user * CWE can be -1 if not defined, can't be uint * Query also had CweID * Disabled predicates-fetch in sarif generation * Removing leftover info log message * Better error handling * fixed default preset configuration * removing .bat files - sorry * Cleanup per initial review * refactoring per Gist, fixed project find, add apps * small fix - sorry for commit noise while testing * Fixing issues with incremental scans. * removing maxretries * Updated per PR feedback, further changes todo toda * JSON Report changes and reporting cleanup * removing .bat (again?) * adding docs, groovy unit test, linter fixes * Started adding tests maybe 15% covered * fix(checkmarxOne): test cases for pkg and reporting * fix(checkmarxOne):fix formatting * feat(checkmarxone): update interface with missing method * feat(checkmarxone):change runStep signature to be able to inject dependency * feat(checkmarxone): add tests for step (wip) * Adding a bit more coverage * feat(checkmarxOne): fix code review * feat(checkmarxOne): fix code review * feat(checkmarxOne): fix code review * feat(checkmarxOne): fix integration test PR * adding scan-summary bug workaround, reportgen fail * enforceThresholds fix when no results passed in * fixed gap when preset empty in yaml & project conf * fixed another gap in preset selection * fix 0-result panic * fail when no preset is set anywhere * removed comment * initial project-under-app support * fixing sarif reportgen * some cleanup of error messages * post-merge test fixes * revert previous upstream merge * adding "incremental" to "full" triggers * wrong boolean * project-in-application api change prep * Fixing SARIF report without preset access * fix sarif deeplink * removing comments * fix(cxone):formatting * fix(cxone):formatting * small sarif fixes * fixed merge * attempt at pulling git source repo branch * fix(cxone):new endpoint for project creation * fix(cxOne): taxa is an array * fix(cxOne): get Git branch from commonPipelineEnvironment * fix(cxOne): add params to tag a scan and a project * fix(cxOne): unit test - update project * fix(cxOne): unit test - update project tags * fix(cxOne): improve logs * fix(cxOne): improve logs * adding RequestNewPDFReport function using v2 api * added version check * fix(cxone): JSON report using v2 API * update to set reportType in v2 reportgen * fix(checkmarxOneExecuteScan): remove absolute patch for code preview * fix(checkmarxOneExecuteScan): remove SCA confusion from driver name * fix(checkmarxOneExecuteScan): search project name by exact match * fix(checkmarxOneExecuteScan): escape branch name in deeplink * fix(checkmarxOneExecuteScan): fix format * fix(checkmarxOneExecuteScan): include Low severity; add Proposed Not Exploitable status to the report --------- Co-authored-by: michael kubiaczyk <michael.kubiaczyk@checkmarx.com> Co-authored-by: michaelkubiaczyk <48311127+michaelkubiaczyk@users.noreply.github.com> Co-authored-by: sumeet patil <sumeet.patil@sap.com> Co-authored-by: Adrien <99400874+hubadr@users.noreply.github.com>
1 parent 5707fb8 commit 46fcdd1

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

pkg/checkmarxone/checkmarxone.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,6 +1376,17 @@ func (sys *SystemInstance) RequestNewReportV2(scanID, reportType string) (string
13761376
},
13771377
"filters": map[string][]string{
13781378
"scanners": {"sast"},
1379+
"severities": {
1380+
"high",
1381+
"medium",
1382+
"low",
1383+
},
1384+
"states": {
1385+
"to-verify",
1386+
"confirmed",
1387+
"urgent",
1388+
"proposed-not-exploitable",
1389+
},
13791390
},
13801391
"reportType": "ui",
13811392
"fileFormat": reportType,

0 commit comments

Comments
 (0)