Skip to content

fix: alignment fallback ui5 versions #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2025
Merged

fix: alignment fallback ui5 versions #3861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82f49a3
fix: alignment fallback ui5 versions
longieirl Nov 24, 2025
0b49a16
fix: add changeset
longieirl Nov 24, 2025
b5a371b
fix: align changes
longieirl Nov 24, 2025
c10953d
fix: align date
longieirl Nov 24, 2025
13a78e1
Merge branch 'main' into 1953/alignment-nov
longieirl Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/crisp-adults-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sap-ux/ui5-info': patch
---

Alignment of UI5 fallback versions
4 changes: 2 additions & 2 deletions packages/ui5-info/src/ui5-version-fallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ export const supportState = {
skipped: 'Skipped'
} as const;

// Updated Nov-06-2025 from https://ui5.sap.com/versionoverview.json
// Updated Nov-24-2025 from https://ui5.sap.com/versionoverview.json
export const ui5VersionFallbacks = [
{
version: '1.142.*',
support: supportState.maintenance
},
{
version: '1.141.*',
support: supportState.maintenance
support: supportState.outOfMaintenance
},
{
version: '1.140.*',
Expand Down
19 changes: 0 additions & 19 deletions packages/ui5-info/test/__snapshots__/ui5-version-info.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4995,10 +4995,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver
"maintained": true,
"version": "1.142.0",
},
{
"maintained": true,
"version": "1.141.0",
},
{
"maintained": true,
"version": "1.139.0",
Expand Down Expand Up @@ -5035,9 +5031,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down Expand Up @@ -5067,9 +5060,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down Expand Up @@ -5099,9 +5089,6 @@ exports[`getUI5Versions: Handle error cases while getting UI5 versions: UI5 ver
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down Expand Up @@ -5131,9 +5118,6 @@ exports[`getUI5Versions: Handle fatal cases while getting UI5 versions: UI5 ver
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down Expand Up @@ -5163,9 +5147,6 @@ exports[`getUI5Versions: Handle fatal cases while getting UI5 versions: UI5 ver
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down
5 changes: 1 addition & 4 deletions packages/ui5-info/test/commands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,12 @@ describe('Retrieve NPM UI5 mocking spawn process', () => {
onlyNpmVersion: true
}); // expect defaults
expect(retrievedUI5Versions[0]).toEqual({ version: '1.142.0' });
expect(retrievedUI5Versions.length).toEqual(9);
expect(retrievedUI5Versions.length).toEqual(8);
expect(retrievedUI5Versions).toMatchInlineSnapshot(`
[
{
"version": "1.142.0",
},
{
"version": "1.141.0",
},
{
"version": "1.139.0",
},
Expand Down
Loading