Skip to content

Bootstrap attribute "logLevel" should be reported as a warning finding #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flovogt opened this issue Mar 12, 2025 · 0 comments · Fixed by #603
Closed

Bootstrap attribute "logLevel" should be reported as a warning finding #602

flovogt opened this issue Mar 12, 2025 · 0 comments · Fixed by #603
Assignees
@flovogt
Labels
detection An issue related to detection capabilities

Comments

@flovogt
Copy link
Member

flovogt commented Mar 12, 2025 •
edited
Loading

Hi team,

for following HTML file we should report a warning finding to use data-sap-ui-log-level instead of data-sap-ui-logLevel. Documented here https://sdk.openui5.org/topic/91f2d03b6f4d1014b6dd926db0e91070.

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>MyApp</title>
    <script
      id="sap-ui-bootstrap"
      src="../resources/sap-ui-core.js"
      data-sap-ui-theme="sap_horizon"
      data-sap-ui-resource-roots='{
         "myapp": "./",
      }'
      data-sap-ui-on-init="module:myapp/index"
      data-sap-ui-language="en"
      data-sap-ui-logLevel="none"
      data-sap-ui-async="true"
      data-sap-ui-compat-version="edge"
    ></script>
  </head>
  <body class="sapUiBody">
    <div
      data-sap-ui-component
      data-name="myapp"
      data-id="container"
      data-settings='{"id" : "app"}'
      id="content"
    ></div>
  </body>
</html>

Currently no finding is reported at all.
@flovogt flovogt added the detection An issue related to detection capabilities label Mar 12, 2025
@flovogt flovogt self-assigned this Mar 13, 2025
flovogt added a commit that referenced this issue Mar 13, 2025
@flovogt
fix: Detect outdated notation for bootstrap attribute log-level
74c560e 
Fixes #602
@flovogt flovogt mentioned this issue Mar 13, 2025
Merged
flovogt added a commit that referenced this issue Mar 17, 2025
@flovogt
fix: Detect outdated notation for bootstrap attribute log-level
33d8809 
Fixes #602
flovogt added a commit that referenced this issue Mar 17, 2025
@flovogt
fix: Detect outdated notation for bootstrap attribute log-level
e6158f2 
Fixes #602
flovogt added a commit that referenced this issue Mar 17, 2025
@flovogt
fix: Detect outdated notation for bootstrap attribute log-level (#603)
4fb76f8 
Fixes #602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flovogt flovogt

Labels
detection An issue related to detection capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Detect outdated notation for bootstrap attribute log-level SAP/ui5-linter
1 participant
@flovogt