Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Layer Filter Catch #381

Open
allywarner opened this issue Oct 30, 2020 · 2 comments
Open

Refactor Layer Filter Catch #381

allywarner opened this issue Oct 30, 2020 · 2 comments
Milestone
Backlog

Comments

@allywarner
Copy link
Contributor

allywarner commented Oct 30, 2020 •
edited
Loading

In LayerFilter.cc line 939, there is a try catch that doesn't throw an exception so they will be skipped undetected. This is high-level code and will take some work to find proper exceptions for different layers.
@allywarner allywarner added this to the Backlog milestone Oct 30, 2020
@allywarner
Copy link
Contributor Author

This was a problem again. @jessdtate should at least some error or log message come through instead of doing nothing and then reporting success?

@jessdtate
Copy link
Contributor

log/error would work be fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jessdtate @allywarner