Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake version checks for our VTK based adaptors that use VTK 9 unstructured grid zero-copy API #66

Open
kwryankrattiger opened this issue May 13, 2022 · 1 comment

Comments

@kwryankrattiger
Copy link
Contributor

Testing integration with the libsim/visit adapter and the VTK-IO adapter exposed an issue in the SVTKUtils. It seems the SVTKUtils were written to work only with a VTK 9.x.x.

I have not tested explicitly which versions don't work, but it does not work with and of the VTK 8.x.x versions used by visit but it does work with the VTK inside of ParaView 5.10 when catalyst is on (roughly VTK 9).

There seem to be two options, either write variations of the SVTKUtils that work with VTK 8 or disable the VTK adapters when building the Visit adapters.

@burlen

@burlen
Copy link
Contributor

burlen commented May 16, 2022

This is a consequence of backward incompatible changes between VTK 8 and 9 unstructured meshes and the massive performance degradation associated with using the VTK < 9 zero-copy API with newer VTK 9. We don't have the resources to support VTK < 9. However, it would be OK to add support for VTK < 9 if a patch for this were to come from the community. we should add CMake Version check for VTK 9 for our adaptors that make use of VTK 9 unstructured mesh zero-copy API so that the situation is clear.

@burlen burlen changed the title libsim/VTK-IO integration error: Sensei requires VTK 9 for VTK adapters but Visit requires VTK 8 Add CMake version checks for our VTK based adaptors that use VTK 9 unstructured grid zero-copy API May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants