You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #415 introduced some bugs and issues that must be fixed.
globmatch was changed to regex in the query() method of some python storage plugins. This is a bug that must be fixed. We want a consistent behaviour between all storage plugins, regardless whether they are implemented in C or Python.
In many places was several statements combined into oneliners. First this makes the code less readable. Often this duplicate function calls which are inefficient and in the cases the function has side effects lead to hard to debug bugs.
This must be fixed. Unfortunately all the changes in the code makes it difficult to find these bugs.
Assert statements should not be removed. Used correctly, they are a good way to ensuring code consistency.
Single backticks around variable names in both python and swig interface files was changed to double backticks. That is not in line with google docstrings that dlite uses and makes the docstrings less readable. This should be reverted. If the documentation system for some reason require double backtics, the right solution is to make a copy of the source file using a regex to replace single backticks with double backtics.
Python docstrings should be easy to read with the builtin help function and should not be bloated with triple backticks around code examples. Instead, examples should instead use ">>> " to make them testable with doctest.
The text was updated successfully, but these errors were encountered:
PR #415 introduced some bugs and issues that must be fixed.
globmatch was changed to regex in the query() method of some python storage plugins. This is a bug that must be fixed. We want a consistent behaviour between all storage plugins, regardless whether they are implemented in C or Python.
In many places was several statements combined into oneliners. First this makes the code less readable. Often this duplicate function calls which are inefficient and in the cases the function has side effects lead to hard to debug bugs.
This must be fixed. Unfortunately all the changes in the code makes it difficult to find these bugs.
Assert statements should not be removed. Used correctly, they are a good way to ensuring code consistency.
Single backticks around variable names in both python and swig interface files was changed to double backticks. That is not in line with google docstrings that dlite uses and makes the docstrings less readable. This should be reverted. If the documentation system for some reason require double backtics, the right solution is to make a copy of the source file using a regex to replace single backticks with double backtics.
Python docstrings should be easy to read with the builtin help function and should not be bloated with triple backticks around code examples. Instead, examples should instead use ">>> " to make them testable with doctest.
The text was updated successfully, but these errors were encountered: