Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_package(dlite) fails with CMake 3.26 #518

Closed
jesper-friis opened this issue Mar 26, 2023 · 0 comments · Fixed by #608
Closed

find_package(dlite) fails with CMake 3.26 #518

jesper-friis opened this issue Mar 26, 2023 · 0 comments · Fixed by #608
Labels
bug Something isn't working prioritised Prioritised for current sprint

Comments

@jesper-friis
Copy link
Collaborator

With CMake 3.26, calling find_package(dlite) from within a CMakeLists.txt file suddenly stopped working.

PR #510 added a temporary workaround to ensure that the CI/CD tests runs by manually install cmake 3.25.2 from source. This makes the ci_tests.yaml workflow much slower and is only a correct temporary solution if the cause of the problem is a bug in CMake 3.26.

The task of this issue is to determine whether the cause of the problem is a bug in CMake 3.26 (unlikely) or an issue with the way we generate dliteConfig.cmake from cmake/dliteConfig.cmake.in (much more likely). In the latter case - fix the issue!

You should install CMake 3.26 locally when working with this issue.
@jesper-friis jesper-friis added the bug Something isn't working label Mar 26, 2023
@jesper-friis jesper-friis changed the title Proper cmake fix find_package(dlite) fails with CMake 3.26 Mar 26, 2023
@Treesarj Treesarj added the prioritised Prioritised for current sprint label Jul 10, 2023
@jesper-friis jesper-friis linked a pull request Aug 20, 2023 that will close this issue
Install cmake with pip #608
Merged
9 tasks
@jesper-friis jesper-friis mentioned this issue Aug 20, 2023
Merged
9 tasks
jesper-friis added a commit that referenced this issue Aug 20, 2023
@jesper-friis
Install cmake with pip (#608)
86e38c4 
# Description
Updated ci_tests to install cmake from pip instead of building from
source

Closes #518 

## Type of change
- [x] Bug fix & code cleanup
- [ ] New feature
- [ ] Documentation update
- [ ] Test update

## Checklist for the reviewer
This checklist should be used as a help for the reviewer.

- [ ] Is the change limited to one issue?
- [ ] Does this PR close the issue?
- [ ] Is the code easy to read and understand?
- [ ] Do all new feature have an accompanying new test?
- [ ] Has the documentation been updated as necessary?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working prioritised Prioritised for current sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install cmake with pip SINTEF/dlite
2 participants
@jesper-friis @Treesarj