Skip to content

Commit

Permalink
Revert "Revert "1.7.0-rc1""
Browse files Browse the repository at this point in the history
This reverts commit a090c63.
  • Loading branch information
SKLn-Rad committed Aug 31, 2017
1 parent a090c63 commit f454cb0
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 17 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@
/WebViewPlugin/WebView.Plugin.WinPhone/obj

/UpgradeLog.htm
/WebViewPlugin/WebView.Plugin.WindowsPhone/bin/Release
/WebViewPlugin/WebView.Plugin.WindowsPhone/obj
/WebViewPlugin/WebView.Plugin.WindowsStore/bin
/WebViewPlugin/WebView.Plugin.WindowsStore/obj
1 change: 1 addition & 0 deletions SampleApp/SampleApp.Windows/Package.appxmanifest
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<ApplicationContentUriRules>
<Rule Match="https://www.xamarin.com" Type="include" />
<Rule Match="https://www.google.co.uk" Type="include" />
<Rule Match="https://httpbin.org/headers" Type="include" />
</ApplicationContentUriRules>
</Application>
</Applications>
Expand Down
2 changes: 1 addition & 1 deletion SampleApp/SampleApp.iOS/SampleApp.iOS.csproj.user
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<SelectedDevice>iPad Air 2 iOS 10.3</SelectedDevice>
<SelectedDevice>Simulator</SelectedDevice>
<DefaultDevice>iPad Air 2 iOS 10.3</DefaultDevice>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion SampleApp/SampleApp/App.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class App : Application

public App()
{
MainPage = new HeadersSample();
MainPage = new MainPage();
}

protected override void OnStart()
Expand Down
25 changes: 12 additions & 13 deletions WebViewPlugin/WebView.Plugin.iOS/FormsWebViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -135,20 +135,19 @@ internal void InjectJS(string js)

void OnUserNavigationRequested(FormsWebView sender, string uri, Abstractions.Enumerations.WebViewContentType contentType)
{
if (Element == sender)
if (Element != sender) return;

switch (contentType)
{
switch (contentType)
{
case Abstractions.Enumerations.WebViewContentType.Internet:
CommitNsUrlRequest(new NSUrl(uri));
break;
case Abstractions.Enumerations.WebViewContentType.LocalFile:
LoadLocalContent(uri);
break;
case Abstractions.Enumerations.WebViewContentType.StringData:
Control.LoadHtmlString(uri, new NSUrl(string.Concat("file://", GetCorrectBaseUrl(), "/")));
break;
}
case Abstractions.Enumerations.WebViewContentType.Internet:
CommitNsUrlRequest(new NSUrl(uri));
break;
case Abstractions.Enumerations.WebViewContentType.LocalFile:
LoadLocalContent(uri);
break;
case Abstractions.Enumerations.WebViewContentType.StringData:
Control.LoadHtmlString(uri, new NSUrl(string.Concat("file://", GetCorrectBaseUrl(), "/")));
break;
}
}

Expand Down
4 changes: 2 additions & 2 deletions package.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<package>
<metadata>
<id>Xam.Plugin.WebView</id>
<version>1.6.1</version>
<version>1.7.0-rc1</version>
<title>WebView Plugin for Xamarin Forms</title>
<authors>Ryan Dixon</authors>
<owners>Ryan Dixon</owners>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<description>A simple lightweight HybridWebView designed to work with Xamarin Forms</description>
<releaseNotes>Match Android WebView to parent height/width. Extra NRE checking on UWP.</releaseNotes>
<releaseNotes>Support for iOS 11 and Request Headers.</releaseNotes>
<iconUrl>https://s18.postimg.org/wjfexgtnt/FWV.png</iconUrl>
<tags>Plugins, Xamarin, WebView, Web, HTML, Forms, Android, iOS, UWP, WinRT</tags>
<dependencies>
Expand Down

0 comments on commit f454cb0

Please sign in to comment.