-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
P1Priority: highPriority: highbackendBackend relatedBackend relatedrefactorCode improvementCode improvement
Description
Problem
Default vessel specs (49,000 DWT MR tanker) are hardcoded in multiple places:
api/main.pyline ~368-378:VesselConfigPydantic model with defaultsapi/main.pyline ~426:VesselSpecs()uses module-level defaultstests/integration/test_api.pyline ~87-96: test fixtures repeat the same values
Impact
- Changing default specs requires updates in 3+ places
- Risk of inconsistency between code paths
- Tests may not reflect actual defaults
Steps to fix
- Create a single canonical source (e.g.
DEFAULT_VESSELconstant or config) - Reference it from
VesselConfig, global state init, and test fixtures - Document the default vessel in one place
Files
api/main.pytests/integration/test_api.py
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1Priority: highPriority: highbackendBackend relatedBackend relatedrefactorCode improvementCode improvement