Skip to content

Commit 751d6fe

Browse files
committed
Fix: format_expressions star rewrite
1 parent a750efb commit 751d6fe

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sqlmesh/core/dialect.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,9 +379,8 @@ def format_model_expressions(
379379
comments = expression.comments
380380
expression.comments = None
381381

382-
if not isinstance(expression, exp.Alias):
383-
if expression.name:
384-
expression = expression.replace(exp.alias_(expression, expression.name))
382+
if not isinstance(expression, exp.Alias) and expression.output_name not in ("", "*"):
383+
expression = expression.replace(exp.alias_(expression, expression.output_name))
385384

386385
column = column or expression
387386
expression = expression.this

tests/core/test_dialect.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ def test_format_model_expressions():
2121
, 1);
2222
2323
SELECT
24+
*,
2425
CAST(a AS int),
2526
CAST(b AS int) AS b,
2627
CAST(c + 1 AS int) AS c,
@@ -50,6 +51,7 @@ def test_format_model_expressions():
5051
@DEF(x, 1);
5152
5253
SELECT
54+
*,
5355
a::INT AS a,
5456
b::INT AS b,
5557
CAST(c + 1 AS INT) AS c,

0 commit comments

Comments
 (0)