Optimize Sync: no need to update the status of our files since this is done immediately after by the Editor

SRombauts · SRombauts · commit 522992640512 · 2018-01-06T22:12:41.000+01:00
Part of #28 Optimization: many operations leads to double call to UpdateStatus()
diff --git a/Source/PlasticSourceControl/Private/PlasticSourceControlOperations.cpp b/Source/PlasticSourceControl/Private/PlasticSourceControlOperations.cpp
@@ -705,10 +705,7 @@ bool FPlasticSyncWorker::Execute(FPlasticSourceControlCommand& InCommand)
 			ProjectDirs.Add(FPaths::ConvertRelativePathToFull(FPaths::ProjectConfigDir()));
 			PlasticSourceControlUtils::RunUpdateStatus(ProjectDirs, InCommand.Concurrency, InCommand.ErrorMessages, States, InCommand.ChangesetNumber, InCommand.BranchName);
 		}
-		else
-		{
-			PlasticSourceControlUtils::RunUpdateStatus(InCommand.Files, InCommand.Concurrency, InCommand.ErrorMessages, States, InCommand.ChangesetNumber, InCommand.BranchName);
-		}
+		// else: optim, no need to update the status of our files since this is done immediately after by the Editor
 	}
 
 	return InCommand.bCommandSuccessful;

Original file line number	Diff line number	Diff line change
`@@ -705,10 +705,7 @@ bool FPlasticSyncWorker::Execute(FPlasticSourceControlCommand& InCommand)`
`705`	`705`	`ProjectDirs.Add(FPaths::ConvertRelativePathToFull(FPaths::ProjectConfigDir()));`
`706`	`706`	`PlasticSourceControlUtils::RunUpdateStatus(ProjectDirs, InCommand.Concurrency, InCommand.ErrorMessages, States, InCommand.ChangesetNumber, InCommand.BranchName);`
`707`	`707`	`}`
`708`		`- else`
`709`		`- {`
`710`		`- PlasticSourceControlUtils::RunUpdateStatus(InCommand.Files, InCommand.Concurrency, InCommand.ErrorMessages, States, InCommand.ChangesetNumber, InCommand.BranchName);`
`711`		`- }`
	`708`	`+ // else: optim, no need to update the status of our files since this is done immediately after by the Editor`
`712`	`709`	`}`
`713`	`710`
`714`	`711`	`return InCommand.bCommandSuccessful;`