You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert back the implementation of FPlasticSourceControlProvider::UsesFileRevisions() to match what is used upstream in Unreal Engine
This API is broken, it was created to prevent users to Sync individual assets, but it is now preventing users to check-in with the context menu, as well as selecting files from the Submit window
// Only a partial workspace can sync files individually like Perforce, a regular workspace needs to update completely
return IsPartialWorkspace();
I believe that the logic is in fact flawed from what we would expect!
IMO Context & selected check-in should be forbidden if the provider use changelists, not the reverse!
(and using changelists could become a setting)
NOTE: the bug was introduced in UE5.1 by:
Commit 5803c744 by marco anastasi, 10/04/2022 02:36 AM
Remove / disable 'Check-in' context menu item in Content Explorer and Scene Outliner for Source Control providers that do not use changelists
#rb stuart.hill, wouter.burgers
#preflight 633ac338c37844870ac69f67
[CL 22322177 by marco anastasi in ue5-main branch]
//TODO this is the wrong usage for UsesChangelists()
435
-
returntrue; //We don't want to show ChangeList column anymore (Plastic SCM term would be ChangeSet) BUT we need this to display the changelists in the source control menu
434
+
//We don't want to show ChangeList column anymore (Plastic SCM term would be ChangeSet) BUT we need this to display the changelists in the source control menu
435
+
returntrue; //TODO: we should make this configurable, in order for users to be able to hide the View Changelists window from the menu
0 commit comments