Skip to content

Kick Request Disable and Arm Have Incorrect Default Initialization #29

@guyfleeman

Description

@guyfleeman

The the KickRequest enum that commands the kicker's charge and kick behavior, the KR_ARM entry is in slot 1 (assigned a value of 0) and KR_DISABLE is in slot 2 (assigned a value of 1). This means a zero initialized packet will command the kicker to charge. This is also why some firmware test images charge the kicker on initial communication despite kicking not being part of the test. This is not safe default behavior and should be changed in the packet version bump.

It will probably land with torque control updates.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions