From cdb6f5ae1e620c90a7423c7777246ba8b6ca1aa3 Mon Sep 17 00:00:00 2001 From: jernejp21 Date: Tue, 9 Aug 2022 10:45:05 +0900 Subject: [PATCH 1/2] OpenAMP semaphore init before first use HSEM clock was enabled after first use, resulting in endless loop without error exception. Moved HSEM clock enable before first use. --- .../Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c | 5 +++-- .../Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c b/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c index 31891c99..e2e01679 100644 --- a/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c +++ b/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c @@ -97,12 +97,13 @@ int main(void) ((HAL_GetHalVersion() >> 24) & 0x000000FF), ((HAL_GetHalVersion() >> 16) & 0x000000FF), ((HAL_GetHalVersion() >> 8) & 0x000000FF)); + /*HW semaphore Clock enable*/ + __HAL_RCC_HSEM_CLK_ENABLE(); + BSP_LED_Init(LED7); BSP_LED_On(LED7); /* USER CODE END Init */ - /*HW semaphore Clock enable*/ - __HAL_RCC_HSEM_CLK_ENABLE(); /* IPCC initialisation */ MX_IPCC_Init(); /* OpenAmp initialisation ---------------------------------*/ diff --git a/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c b/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c index d2ac51d0..6b67da39 100644 --- a/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c +++ b/Projects/STM32MP157C-DK2/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c @@ -97,12 +97,13 @@ int main(void) ((HAL_GetHalVersion() >> 24) & 0x000000FF), ((HAL_GetHalVersion() >> 16) & 0x000000FF), ((HAL_GetHalVersion() >> 8) & 0x000000FF)); + /*HW semaphore Clock enable*/ + __HAL_RCC_HSEM_CLK_ENABLE(); + BSP_LED_Init(LED7); BSP_LED_On(LED7); /* USER CODE END Init */ - /*HW semaphore Clock enable*/ - __HAL_RCC_HSEM_CLK_ENABLE(); /* IPCC initialisation */ MX_IPCC_Init(); /* OpenAmp initialisation ---------------------------------*/ From 72faa0b9ff1e9d4ef4844b990296c844492ee4b7 Mon Sep 17 00:00:00 2001 From: jernejp21 <61543115+jernejp21@users.noreply.github.com> Date: Thu, 11 Aug 2022 14:37:14 +0900 Subject: [PATCH 2/2] OpenAMP semaphore init before first use Changed also on STM32MP157C-EV1 samples. --- .../Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c | 5 +++-- .../Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c b/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c index 3d1020a0..3a56e350 100644 --- a/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c +++ b/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_TTY_echo/Src/main.c @@ -97,12 +97,13 @@ int main(void) ((HAL_GetHalVersion() >> 24) & 0x000000FF), ((HAL_GetHalVersion() >> 16) & 0x000000FF), ((HAL_GetHalVersion() >> 8) & 0x000000FF)); + /*HW semaphore Clock enable*/ + __HAL_RCC_HSEM_CLK_ENABLE(); + BSP_LED_Init(LED4); BSP_LED_On(LED4); /* USER CODE END Init */ - /*HW semaphore Clock enable*/ - __HAL_RCC_HSEM_CLK_ENABLE(); /* IPCC initialisation */ MX_IPCC_Init(); /* OpenAmp initialisation ---------------------------------*/ diff --git a/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c b/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c index 3fe63a5c..7db8f0b5 100644 --- a/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c +++ b/Projects/STM32MP157C-EV1/Applications/OpenAMP/OpenAMP_for_signed_fw/Src/main.c @@ -97,12 +97,13 @@ int main(void) ((HAL_GetHalVersion() >> 24) & 0x000000FF), ((HAL_GetHalVersion() >> 16) & 0x000000FF), ((HAL_GetHalVersion() >> 8) & 0x000000FF)); + /*HW semaphore Clock enable*/ + __HAL_RCC_HSEM_CLK_ENABLE(); + BSP_LED_Init(LED4); BSP_LED_On(LED4); /* USER CODE END Init */ - /*HW semaphore Clock enable*/ - __HAL_RCC_HSEM_CLK_ENABLE(); /* IPCC initialisation */ MX_IPCC_Init(); /* OpenAmp initialisation ---------------------------------*/