more defensive catch for cert revoke check

johanlundberg · johanlundberg · commit 12aa26bdd390 · 2024-08-05T13:54:30.000+02:00
diff --git a/src/auth_server/cert_utils.py b/src/auth_server/cert_utils.py
@@ -77,7 +77,7 @@ async def is_cert_revoked(cert: Certificate, ca_name: str) -> bool:
         return is_revoked(
             cert=PKIToolCertificate.from_cryptography(cert=cert), chain=Chain.from_cryptography([ca_cert])
         )
-    except PKIToolsError as e:
+    except (PKIToolsError, ValueError) as e:
         logger.error(f"Certificate {rfc8705_fingerprint(cert)} failed revoke check: {e}")
     return True
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ async def is_cert_revoked(cert: Certificate, ca_name: str) -> bool:`
`77`	`77`	`return is_revoked(`
`78`	`78`	`cert=PKIToolCertificate.from_cryptography(cert=cert), chain=Chain.from_cryptography([ca_cert])`
`79`	`79`	`)`
`80`		`- except PKIToolsError as e:`
	`80`	`+ except (PKIToolsError, ValueError) as e:`
`81`	`81`	`logger.error(f"Certificate {rfc8705_fingerprint(cert)} failed revoke check: {e}")`
`82`	`82`	`return True`
`83`	`83`